Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug target to makefile. #30

Open
Stewori opened this issue Jul 25, 2018 · 2 comments
Open

Add debug target to makefile. #30

Stewori opened this issue Jul 25, 2018 · 2 comments

Comments

@Stewori
Copy link
Owner

Stewori commented Jul 25, 2018

In #10 it was explained how to build JyNI in debug mode. That requires editing the makefile so we should better have a build target for debug. I created this issue to keep track of that idea.

@CalumFreeman
Copy link
Contributor

CalumFreeman commented Jul 26, 2018

I've added a basic debug build target, it just compiles with the -g flag which adds debug symbols to the file (I also added a tests target that just prints a message saying it isn't implemented yet). The pull request is 31.

@Stewori
Copy link
Owner Author

Stewori commented Jul 26, 2018

Alright, that's a good start. Even more elegant than what I had in mind -- I wasn't aware of += notation for makefiles. According to https://clang.llvm.org/docs/UsersManual.html#controlling-debug-information the -g flag should also work for clang so we can readily apply the same enhancement to makefile.clang and makefile.osx. For msvc we probably want /Zi, see https://msdn.microsoft.com/en-us/library/958x11bc.aspx. However it might be necessary to handle the .pdb files that are created in addition to the .obj files then. E.g. for clean up, but maybe they also need to be passed to the linker, I'm not sure right now.
@CalumFreeman It's fine if you focus on Linux now, the notes on other OS' are just because in the long run we should be able to have debug builds there as well. I'll leave the issue open until we found solutions for the other makefiles.

CalumFreeman added a commit to CalumFreeman/JyNI that referenced this issue Aug 16, 2018
for -g flag see [Issue 30](Stewori#30)
the tests targets may not work but they print an error to that effect
Moving and splitting out cleans should also work on all the systems
CalumFreeman added a commit to CalumFreeman/JyNI that referenced this issue Aug 30, 2018
for -g flag see [Issue 30](Stewori#30)
the tests targets may not work but they print an error to that effect
Moving and splitting out cleans should also work on all the systems
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants