Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinning the pre-commit hook version doesn't pin the regal version #1064

Open
paddycarey opened this issue Sep 5, 2024 · 2 comments
Open
Labels
help wanted Extra attention is needed

Comments

@paddycarey
Copy link

Hi, I'm not sure if this is by design or not, but we noticed today after the 0.26.0 release that a newer version of regal was being downloaded in our pre-commit hook than what we thought we had pinned (0.24.0).

It looks like the download script defaults to latest, is it somehow possible to pin the regal version along with the pre-commit hook?

Thanks!

@paddycarey
Copy link
Author

ah, i just noticed in the docs

Downloads the latest regal binary from Github.

It'd be nice to be able to specify the version for the regal-download hook to avoid the need for a local Go toolchain.

@anderseknert
Copy link
Member

Hey Paddy! And thanks for reporting that. Honestly I'm a bit rusty on how those hooks work, and that code was contributed by folks from the community who wanted them. If you have an idea for how to best update the scripts to allow versioning, I'd be grateful for a PR! If not, I can try to look into it sometime next week or so.

@anderseknert anderseknert added the help wanted Extra attention is needed label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants