Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Wave conversational model stuff from SwellRT #201

Open
pablojan opened this issue Oct 28, 2016 · 0 comments
Open

Remove Wave conversational model stuff from SwellRT #201

pablojan opened this issue Oct 28, 2016 · 0 comments

Comments

@pablojan
Copy link
Contributor

Current version of SwellRT still keeps logic from the original Wave conversational model:

  • On Wave creation, avoid conversational root wavelet and personal-data wavelet creation.

The WaveView interface includes conversational-related methods that doesn't fit in the Wave model semantics:

WaveView.createRoot()
WaveView.getRoot()
Wavelet createUserData()
Wavelet getUserData()

Personal data wavelets and root wavelets are not used in the SwellRT data model and they cause perfomance issues on the server when Wave is loaded into memory.

  • On Wave loading (client), remove conversation model logic. In StageTwo class, remove methods
getConversations()
getSupplement()
getReadMonitor()
getModelIdMapper() // ?
swartz-p2pvalue pushed a commit to Grasia/swellrt that referenced this issue Nov 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant