Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weaver components should switch to ESLint #462

Open
jeremythuff opened this issue Oct 27, 2021 · 1 comment
Open

Weaver components should switch to ESLint #462

jeremythuff opened this issue Oct 27, 2021 · 1 comment
Labels
5 Two and half days of work enhancement New feature or request patch Development requiring a patch version change

Comments

@jeremythuff
Copy link
Member

jeremythuff commented Oct 27, 2021

Currently, we are using TSLint, which has been deprecated. ESLint should be used instead.

This will require introducing a configuration for ESLint which mirrors the settings we have configured for TSLint. In addition to this, our linting process is implicated in our build process and this will need to be switched over to ESLint.

This will require the removal of codelyzer
and angular-tslint-rules.

Additionally there are tslint comments throughout code which will need to be updated to eslint style comments.

A possible aid to this task could be using the angular CLI to create a fresh project and observe the linting setup within that new project.

References:

@jeremythuff jeremythuff added enhancement New feature or request patch Development requiring a patch version change 5 Two and half days of work labels Oct 27, 2021
@kaladay
Copy link
Contributor

kaladay commented Sep 1, 2022

As of TAMULib/tamu-library-components#429 (PR = TAMULib/tamu-library-components#430), the TSLint is removed.
However, the implementation provided there still utilizes TSLint functionality via wrappers.
I suggest that this issue be re-interpretated as to remove the remaining TSLint code and use ESLint properly.

Secondly, there is a problem with ESLint that maay need to be solved:

TypeError: message.trim is not a function

This is an upstream problem that needs to be fixed. I will report this bug upsream if it isn't already reported. With any luck this will eventually be fixed upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 Two and half days of work enhancement New feature or request patch Development requiring a patch version change
Projects
None yet
Development

No branches or pull requests

2 participants