Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Entity "leak" #80

Open
minghuaw opened this issue Apr 9, 2022 · 2 comments
Open

[Bug] Entity "leak" #80

minghuaw opened this issue Apr 9, 2022 · 2 comments

Comments

@minghuaw
Copy link
Contributor

minghuaw commented Apr 9, 2022

Description of the bug

The oven would "leak" entity if its max_theta is larger than zero.

Cause

An empty entity is created on line 212, which is before the line where whether the atom should be created is checked (line 216). If a non-zero max_theta is found, the omitted atoms will leave empty entities that are never deleted and thus causing entities to "leak".

let new_atom = entities.create();

if theta > oven.max_theta {

@ElliotB256
Copy link
Collaborator

Thanks for the report! Do you want to raise a PR or should I?

@minghuaw
Copy link
Contributor Author

minghuaw commented Apr 9, 2022

Could you please do the PR on the upstream? I have got some uncommitted modifications downstream. Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants