Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation should tell to load the TelemetryDeck SDK async? #9

Open
Timac opened this issue Sep 15, 2024 · 1 comment
Open

Documentation should tell to load the TelemetryDeck SDK async? #9

Timac opened this issue Sep 15, 2024 · 1 comment
Assignees

Comments

@Timac
Copy link

Timac commented Sep 15, 2024

The installation instructions of TelemetryDeck for a website are:

<script
  src="https://cdn.telemetrydeck.com/websdk/telemetrydeck.min.js"
  data-app-id="<YOUR APP ID>"
></script>

This means that downloading the TelemetryDeck SDK is blocking the browser. Shouldn't async be used to tell the browser to download the script in parallel with the rest of the page? Or am I missing something because I don't think that TelemetryDeck need to block the rendering of your page?

<script async
  src="https://cdn.telemetrydeck.com/websdk/telemetrydeck.min.js"
  data-app-id="<YOUR APP ID>"
></script>

See the documentation here:

@pichfl
Copy link
Contributor

pichfl commented Sep 16, 2024

Yes, we should add the keyword. No, there is no need for the script to be blocking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants