Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcuts for Configurations #47

Open
IAmVigneswaran opened this issue Jan 31, 2024 · 12 comments
Open

Shortcuts for Configurations #47

IAmVigneswaran opened this issue Jan 31, 2024 · 12 comments
Assignees
Labels
enhancement New Feature Or Request
Milestone

Comments

@IAmVigneswaran
Copy link
Contributor

@milanvarady Would it be possible to assign shortcut to Configurations?

We can have a Assign Shortcut menu when right-clicking Configurations.

configuration-shortcuts-01

Once assigned, the shortcuts would appear on Configurations menu.

configuration-shortcuts-02

Users can easily switch between Configurations by press, ⌘ + 1, ⌘ + 3 , ⌘ + 3 .... ⌘ + 9
Users can have up to 9 assignable shortcuts.

@IAmVigneswaran IAmVigneswaran added the enhancement New Feature Or Request label Jan 31, 2024
@IAmVigneswaran
Copy link
Contributor Author

@milanvarady For Discard Changes can we have global ⌘ + z. Users can press ⌘ + z anywhere within Marker Data to Discard Changes. Similar to ⌘ + s`

Thank you.

@IAmVigneswaran IAmVigneswaran changed the title Ability to Add Shortcuts to Configurations Shortcuts for Configurations Feb 4, 2024
@milanvarady
Copy link
Contributor

@IAmVigneswaran I think we can do this in a subsequent update. Let's focus on the main tasks.

@milanvarady milanvarady added the future idea Features to add in future label Feb 4, 2024
@IAmVigneswaran
Copy link
Contributor Author

I think we can do this in a subsequent update. Let's focus on the main tasks.

@milanvarady We can just add ⌘ + z for Discard Changes for now.

@milanvarady
Copy link
Contributor

@IAmVigneswaran I added the global shortcut for discarding changes.

@IAmVigneswaran
Copy link
Contributor Author

@milanvarady Just tested ⌘ + z for Discard Changes. But for some reason, pressing ⌘ + z does not seems to Discard Changes.

@milanvarady
Copy link
Contributor

Just tested ⌘ + z for Discard Changes. But for some reason, pressing ⌘ + z does not seems to Discard Changes.

Should be fixed now.

@IAmVigneswaran
Copy link
Contributor Author

Just tested ⌘ + z for Discard Changes. But for some reason, pressing ⌘ + z does not seems to Discard Changes.

Should be fixed now.

It is still not working.

discard-changes

@milanvarady
Copy link
Contributor

I have made adjustments to the change checking logic. I hope it's fixed now. 🤞

@IAmVigneswaran
Copy link
Contributor Author

I have made adjustments to the change checking logic. I hope it's fixed now. 🤞

@milanvarady Now there is another issue. Each time, when a change is made, the Change badge is not appearing.

And when a change is made, the Discard Changes is grey out.

@milanvarady
Copy link
Contributor

@IAmVigneswaran With the new configuration system, the changes bug should be fixed.

@IAmVigneswaran
Copy link
Contributor Author

With the new configuration system, the changes bug should be fixed.

Thank you!

@IAmVigneswaran IAmVigneswaran added this to the 1.1.0 milestone Feb 28, 2024
@IAmVigneswaran IAmVigneswaran removed the future idea Features to add in future label Jul 1, 2024
@IAmVigneswaran
Copy link
Contributor Author

@milanvarady Let's aim "assign shortcut to Configurations" feature for 1.1.0 by end of Nov - Dec.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Feature Or Request
Projects
None yet
Development

No branches or pull requests

2 participants