Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Codebase for Xcode 16.0 compatibility and Integration with Marker Data #110

Closed
IAmVigneswaran opened this issue Sep 20, 2024 · 6 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@IAmVigneswaran
Copy link
Contributor

IAmVigneswaran commented Sep 20, 2024

TheAcharya/MarkerData#106

@orchetect When you have time you can tweak the codebase.

And @milanvarady could make the necessary tweaks back in Marker Data.

Thank you.

@IAmVigneswaran IAmVigneswaran added bug Something isn't working enhancement New feature or request labels Sep 20, 2024
@IAmVigneswaran IAmVigneswaran added this to the 0.4.0 milestone Sep 20, 2024
@orchetect orchetect self-assigned this Sep 20, 2024
@orchetect
Copy link
Contributor

orchetect commented Sep 20, 2024

I've updated the codebase for compatibility with Xcode 16 / Swift 6, which also removes the compile warnings.

I also refactored some internal code related to image generation to use modern Swift Concurrency async/await patterns, which has cleaned it up a bit and should make it safer. None of the public API has changed.

Next I can have a look at Marker Data and see what conformances @milanvarady has added there to types exported from MarkersExtractor. From what I saw, it's mostly Identifiable conformances. Those I may move to MarkersExtractor since that's a common protocol used with SwiftUI and would not only be beneficial to anyone using MarkersExtractor as a library. But it's also better coding architecture, which is the reason for the compile warnings in the first place.

@orchetect
Copy link
Contributor

Ok I've done the appropriate refactors and will release 0.3.10 shortly.

I am making the necessary counter-adjustments to Marker Data on a separate branch and will push a Pull Request to the Marker Data once MarkersExtractor 0.3.10 is ready.

@orchetect orchetect modified the milestones: 0.4.0, 0.3.10 Sep 21, 2024
@IAmVigneswaran
Copy link
Contributor Author

Thank you!

@orchetect orchetect added the pending closure This issue is completed and will be closed soon label Sep 21, 2024
@orchetect
Copy link
Contributor

I've been updating my other open-source libraries and apps for new language features, Swift Concurrency, and better compatibility with Xcode 16 and the Swift 6 toolchain.

So a couple of dependencies have been improved (TimecodeKit, DAWFileKit) and some API has changed (mostly making various methods async), so I will push a MarkersExtractor 0.3.11 update with the needed changes in the codebase.

I already refactored MarkersExtractor itself to utilize Swift Concurrency a while ago, so not a lot of changes or improvements are really needed internally. But I can have a look through and see if anything needs polish at some point.

@orchetect
Copy link
Contributor

Will close this, as this is done.

@orchetect orchetect removed the pending closure This issue is completed and will be closed soon label Sep 26, 2024
@IAmVigneswaran
Copy link
Contributor Author

Will close this, as this is done.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants