Skip to content
This repository has been archived by the owner on Sep 26, 2022. It is now read-only.

/styles/reset/ errors after reloading page #115

Closed
Florian-Schoenherr opened this issue Feb 3, 2021 · 10 comments · Fixed by #234
Closed

/styles/reset/ errors after reloading page #115

Florian-Schoenherr opened this issue Feb 3, 2021 · 10 comments · Fixed by #234
Labels
documentation Improvements or additions to documentation

Comments

@Florian-Schoenherr
Copy link
Collaborator

Florian-Schoenherr commented Feb 3, 2021

Uncaught (in promise) TypeError: Cannot read property 'content' of undefined
https://svelte-materialify.vercel.app/styles/reset/

@Florian-Schoenherr Florian-Schoenherr added the documentation Improvements or additions to documentation label Feb 3, 2021
@TheComputerM
Copy link
Owner

Are you sure? this is not a problem for me.

@Florian-Schoenherr
Copy link
Collaborator Author

Florian-Schoenherr commented Feb 3, 2021

with chrome87 + also with chrome88
image
I haven't found any call to .content or something.

@TheComputerM
Copy link
Owner

I am on brave browser chromium version 88, let us check if anyone else has this issue.

@Florian-Schoenherr
Copy link
Collaborator Author

image
inside the gumshoe code

@Florian-Schoenherr
Copy link
Collaborator Author

can't reproduce on firefox-85, google-chrome-88, brave-88

it is an error when the content in body is not loaded and the right nav spy is activated, the spy is controlled by gumshoe

so somewhere it's not passing something in fast enough / passing nothing

@Florian-Schoenherr
Copy link
Collaborator Author

I think gumshoe is dead, this is apparently fixed since 2019: cferdinandi/gumshoe#111

btw I think it happens because the spy assumes there are items? (seems to happen when gumshoe loads before content is available, have also tested with an empty .md file: there the content loads but it always gives back the error (possibly because there are no headers (#toc a's?) present)

@marekdedic
Copy link
Contributor

I can confirm this on FF 86.
Basically, if a page is too short, gumshoe breaks. The workaround is to make the page longer.

@Florian-Schoenherr
Copy link
Collaborator Author

@marekdedic thank you! Does the fix in my PR work on your end? There's a vercel preview.

@marekdedic
Copy link
Contributor

Sorry, haven't tried it. IMHO, vendoring it in is a bad architectural decision... Maybe use an alternative like https://www.npmjs.com/package/menuspy?

@Florian-Schoenherr
Copy link
Collaborator Author

Florian-Schoenherr commented Apr 7, 2021

@marekdedic thank you for the hint, you're right. Will have to see how the API differs, I just wanted the most basic fix for now. Just noticed it's also unmaintained with some issues, so hm.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
3 participants