Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation to reflect ExactlyOnceDelivery for PostgreSQL Pub/Sub #457

Open
thirumal-rafay opened this issue Jul 9, 2024 · 0 comments

Comments

@thirumal-rafay
Copy link

I see that this PR added support for ExactlyOnceDelivery for Postgres, but the documentation may not have been updated to reflect this.

Also, I was reading your tests, and noticed a strange thing at this line. What is special about the Pgx driver where it cannot guarantee ExactlyOnce delivery? Maybe document that fact as well to indicate partial support.

func TestPgxPostgreSQLPublishSubscribe(t *testing.T) {
	t.Parallel()

	features := tests.Features{
		ConsumerGroups:      true,
		ExactlyOnceDelivery: false,
		GuaranteedOrder:     true,
		Persistent:          true,
	}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant