-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add info about MMLib.SwaggerForOcelot to notsupported.rst #1429
base: develop
Are you sure you want to change the base?
Conversation
Hi, some acceptance test failed. But I'm not sure how this can be caused by a change in the documentation. I tried to find a connection, but in vain. |
Hi @TomPallister , Please 🙏 can you check this PR? |
Don't worry! The latest build is green! 😺 |
I will check the PR! Tom has no intention to develop this product because he was greatly inspired by Microsoft's YARP gateway in 2020. 🤣 |
Burgyn commented on Feb 5, 2021:
Wow! I am impressed! So, cool package you've designed and built! 🥇
It uses Ocelot v18 which is .NET 6 release. |
We will not reject your request! Now I need to think about the right way we could move on...
I believe, we need to convert this simple docs updating PR to real feature request, and work more on a sample. And sure we will update docs. So, What about converting your PR to a feature request with more advanced description? Any ideas are welcome! |
Hi @raman-m, thanks for your replays.
Yes I know about that. I understand his decision and I fully respect it.
Thanks, it came out of necessity and people started using it 🙂.
Yes, I'm updating my project. I don't actively follow it, I only do it when someone notifies me. I will do it in the next few days.
It makes sense. I'll take a look at it and try to make a meaningful demo. It won't be right away though, I expect a couple of weeks before I get around to it. |
Hi @raman-m
New version of my package with Ocelot 19 and .NET 7 was released. |
Wow! This is just great news! Congrats! 🥳 Also, could you sync your fork please? Your forked repo is outdated (develop branch). |
Hi,
My forked repository is now up to date. |
Not yet! 😜 |
Done 🙂 |
What about demo and sample app? |
Hi @raman-m, I plan to create a demo and probably submit it as a new PR sometime in December. |
We are waiting you returning to us back in December... |
Should care about #989 too via reopening... ☝️ |
Ah, it was in December '23, yet now it's June 2024. Do you plan to develop a sample project to showcase your library? P.S. The feature branch has been rebased. |
76196c8
to
aed589d
Compare
Hi,
first of all, thank you for this great project and for actively taking care of it.
Many people are still looking for a way to aggregate their microservice documentation directly on the API Gateway. This is what my MMLib.SwaggerForOcelot project provides. I know it doesn't cover all scenarios like people use Ocelot, but a lot of it.
Many people use this package.
I prepared this PR so that people who are looking for a way to do it can find a solution faster. I will be happy if it gets into this documentation. However, I will understand if you reject this PR.
Thank you again.