-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1739 #2177 OpenIddict authentication: role section, override scope and role key #1431
base: develop
Are you sure you want to change the base?
Conversation
@Eits-Ian I see that develop branch in your fork is old. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 failed tests!
Could you review & fix them please?
Sorry I did not get a chance to look at this till today, should be fixed, have added you as a collaborator, I hadn't looked at this for a couple of years. Need to add process policies, I am really busy at the moment so will not be able to get to this for a while. |
The error is at ClaimsToDownstreamPathTests it is not authenticating, I need to take a look at what is happening but it will need to be later |
The branch has been rebased onto release/24.0 which has top commit 59b63ea !
|
@Eits-Ian Dear author, Will this PR close, is PR related to the following issues?
Please answer ASAP❗ P.S.
What is OpenIddict? It should likely not be part of the PR title; instead, the title should include Ocelot's artifact name or, if necessary, the ASP.NET one. |
Raman,
I need to go back and look at the code to see what I did but from memory, you could specify the roles/scopes but not use an authorization policy and it worked with openiddict.
I haven't got much time to do much with this at the moment, I will need to get back into it as I must update the api, that use this, but that will not be for a few months.
Best,
Ian.
|
It should be a matter of weeks, not months! |
Raman,
With all due respect I have a 3-year clinic project just about to open which I am a part owner of the clinic, and this is my priority, I'm not coding all day long.
Best,
Ian.
|
@Eits-Ian |
Raman,
As I said I do need to do it, but I will not be able to get to it for a few months, I currently end up losing days weeks to the clinic, then I get back to some coding but that is only a few hours at a time. In a few months the clinic will be open, and I will get back to this, I wish I had more time now, but I work 7 day weeks and all hours so there is just no more to give.
Best,
Ian.
|
🆗 Got it! You are super busy… In this case, let me decide what to do with this PR… |
SuccessorThis dependency can be addressed by giving high priority to merging this PR first, followed by PR #1478. |
We should introduce a new "scopes matching strategy" feature directly in this PR due to the previously discussed issues in: |
"ScopeKey": "oi_scp" to enable OpenIddict "RequiredRole": [ "User" ]
…lways have its default value null
Registered IRolesAuthorizer Fixed Test should_not_be_valid_if_specified_authentication_provider_isnt_registered()
Fixed test configuration_is_invalid_with_invalid_authentication_provider()
Further Development Required❗The 5 failed acceptance tests need to be addressed! |
Fixes #2177
AllowedScopes
feature is not functioning as anticipated during authentication with the OpenIddict server #2177Proposed Changes
"ScopeKey": "oi_scp"
to enable OpenIddictSuccessor
Closes #1739