Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1658 Adds global header transforms #1659

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

#1658 Adds global header transforms #1659

wants to merge 10 commits into from

Conversation

marklonquist
Copy link

@marklonquist marklonquist commented May 26, 2023 •
edited by raman-m
Loading

Closes #1658

Proposed Changes

  • new global header transforms
  • if route has same header transform key, the global one will not be used

@raman-m raman-m linked an issue May 29, 2023 that may be closed by this pull request
Global UpstreamHeaderTransform settings in GlobalConfiguration section #1658
Open
@raman-m raman-m added feature A new feature medium effort Likely a few days of development effort waiting Waiting for answer to question or feedback from issue raiser labels May 29, 2023
@raman-m raman-m self-requested a review May 29, 2023 11:02
@raman-m raman-m changed the title Adds global header transforms #1658 Adds global header transforms Jun 1, 2023
@raman-m raman-m added in progress Someone is working on the issue. Could be someone on the team or off. and removed waiting Waiting for answer to question or feedback from issue raiser labels Jun 1, 2023
raman-m
raman-m previously approved these changes Jun 3, 2023
View reviewed changes
@raman-m
Copy link
Member

raman-m commented Jun 3, 2023 •
edited
Loading

@marklonquist Thanks Mark! Good job!
I guess overriding global settings by Route local ones are covered by current unit tests, scenarios, right?

Additionally I've added commits to make code quality better.
And finally, Approved it!

@raman-m raman-m added accepted Bug or feature would be accepted as a PR or is being worked on and removed in progress Someone is working on the issue. Could be someone on the team or off. labels Jun 3, 2023
@raman-m raman-m requested a review from TomPallister June 3, 2023 16:52
@TomPallister
Copy link
Member

TomPallister commented Jun 4, 2023 •
edited
Loading

Thanks for the PR! Can you update the docs so people know how to use it?

@raman-m
Copy link
Member

raman-m commented Jun 20, 2023

@TomPallister Yes, we can!
Thank you for your advice!

@raman-m raman-m mentioned this pull request Jul 11, 2023
Merged
@raman-m raman-m force-pushed the feature/1658---Global-UpstreamHeaderTransform-settings-in-GlobalConfiguration-section branch from 9a2c20c to a08f9f9 Compare September 8, 2023 15:07
@raman-m raman-m added needs feedback Issue is waiting on feedback before acceptance and removed medium effort Likely a few days of development effort accepted Bug or feature would be accepted as a PR or is being worked on labels Sep 8, 2023
@raman-m raman-m mentioned this pull request Sep 8, 2023
Open
@raman-m
Copy link
Member

raman-m commented Sep 8, 2023

@marklonquist Hey Mark!
The feature branch has been rebased onto ThreeMammals:develop successfully!
Welcome to code review!

@raman-m
Copy link
Member

raman-m commented Sep 8, 2023 •
edited
Loading

@marklonquist

@TomPallister commented on Jun 4

According to the Tom's request we have to add documentation for this feature.
Do you have time to contribute?

@raman-m raman-m removed the request for review from TomPallister September 8, 2023 15:33
@marklonquist
Copy link
Author

very busy with work and familiy-life. I don't know exactly when I can have time to make docs for this.

@raman-m
Copy link
Member

raman-m commented Oct 30, 2023 •
edited
Loading

@marklonquist commented on Oct 13

🆗 No worries! Take care about your family, and work & life balance!
Our team will return to this PR back after merging of 30+ open PRs with lower numbers... Or, I'll find a mentor...

@raman-m raman-m mentioned this pull request Nov 3, 2023
Closed
@raman-m raman-m added the 2023 Annual 2023 release label Dec 2, 2023
@raman-m raman-m self-assigned this Mar 5, 2024
@raman-m raman-m mentioned this pull request Mar 27, 2024
Closed
@raman-m raman-m force-pushed the feature/1658---Global-UpstreamHeaderTransform-settings-in-GlobalConfiguration-section branch from 7c1b778 to a18b0e7 Compare April 7, 2024 13:54
@raman-m raman-m force-pushed the feature/1658---Global-UpstreamHeaderTransform-settings-in-GlobalConfiguration-section branch from a18b0e7 to 0e27766 Compare April 16, 2024 18:49
@raman-m
Copy link
Member

raman-m commented Apr 16, 2024

The feature branch has been rebased onto release/24.0 with top commit 59b63ea !

@marklonquist Mark,
Could you review and fix failed tests please❓

@raman-m raman-m force-pushed the feature/1658---Global-UpstreamHeaderTransform-settings-in-GlobalConfiguration-section branch from 0e27766 to 2b6ad65 Compare April 19, 2024 17:58
@raman-m
Copy link
Member

raman-m commented May 13, 2024 •
edited
Loading

TODOs

  • Clean up the feature branch from redundant commits related to QoS feature (aka Polly related ones) → cleaned up during rebasing, see the latest force-push

@raman-m raman-m changed the base branch from release/24.0 to develop June 13, 2024 10:16
@raman-m raman-m force-pushed the feature/1658---Global-UpstreamHeaderTransform-settings-in-GlobalConfiguration-section branch from 2b6ad65 to 44b047b Compare June 14, 2024 17:08
@raman-m raman-m added Oct'24 October 2024 release and removed 2023 Annual 2023 release labels Oct 9, 2024
@raman-m raman-m modified the milestones: Annual 2023, October'24 Oct 9, 2024
@raman-m raman-m force-pushed the feature/1658---Global-UpstreamHeaderTransform-settings-in-GlobalConfiguration-section branch from 44b047b to 78a5b3a Compare October 18, 2024 16:41
@raman-m raman-m added Autumn'24 Autumn 2024 release and removed Oct'24 October 2024 release labels Oct 26, 2024
@raman-m raman-m modified the milestones: October'24, Autumn'24 Oct 26, 2024
@raman-m raman-m force-pushed the feature/1658---Global-UpstreamHeaderTransform-settings-in-GlobalConfiguration-section branch from 78a5b3a to 234fe59 Compare November 4, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avdeev99 Avdeev99 Avdeev99 approved these changes

@raman-m raman-m raman-m left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@marklonquist marklonquist

@raman-m raman-m

Labels
Autumn'24 Autumn 2024 release feature A new feature Headers Transform Ocelot feature: Headers Transformation
Projects
None yet
Milestone
Autumn'24
Development

Successfully merging this pull request may close these issues.

Global UpstreamHeaderTransform settings in GlobalConfiguration section
4 participants
@marklonquist @raman-m @TomPallister @Avdeev99