Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fail assertions on invalid savedata in NGC #2426

Open
iphydf opened this issue Nov 16, 2023 · 0 comments
Open

Don't fail assertions on invalid savedata in NGC #2426

iphydf opened this issue Nov 16, 2023 · 0 comments
Milestone
v0.2.20

Comments

@iphydf
Copy link
Member

iphydf commented Nov 16, 2023 •
edited
Loading

E.g. c-toxcore/toxcore/group_pack.c:196: bool load_unpack_self_info(GC_Chat *, Bin_Unpack *): Assertion 'self_nick_len <= MAX_GC_NICK_SIZE' failed.

This shouldn't be an assertion. Any byte sequence is a valid input for loading savedata. We can reject it, but we can't crash the binary on broken saves.
@iphydf iphydf added this to the v0.2.19 milestone Nov 16, 2023
@iphydf iphydf changed the title Don't fail assertions on invalid savedata Don't fail assertions on invalid savedata in NGC Nov 17, 2023
@JFreegman JFreegman mentioned this issue Dec 13, 2023
Merged
@iphydf iphydf modified the milestones: v0.2.19, v0.2.20 Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
DHT Group Chats
Status: Todo
Milestone
v0.2.20
Development

No branches or pull requests
1 participant
@iphydf