Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign Navbar to use icons instead & shows Latency #26

Open
adamseth2 opened this issue Oct 25, 2024 · 1 comment · Fixed by #39
Open

Redesign Navbar to use icons instead & shows Latency #26

adamseth2 opened this issue Oct 25, 2024 · 1 comment · Fixed by #39
Assignees
Labels
Good First Issue Something to tackle as a new member Medium Priority Worth working on Workoad Light A few simple changes

Comments

@adamseth2
Copy link
Collaborator

adamseth2 commented Oct 25, 2024

Context

Currently, the navbar is not dynamic and is too long, causing weird behavior when the width of the window is small. Also, the circle indicators are outdated and could be visually improved with icons.

What to do:

ALREADY DONE
Fix the SCSS to
Currently what it looks like:
image
Replace these circles with icons instead and shrink the names down to:

  • Websocket -> WS:
  • Controller connected -> CTRL:
  • Camera feed -> CAM:
  • (NEW) Lat (shows in ms)

How to implement

Using the vue-material-design-icons, change the color based on the status of the WebSocket, detect controllers plugged in, and show the latency. The current navbar code shows how to change the color based on the states dynamically.

Reference Images:

image
image

@adamseth2 adamseth2 added Good First Issue Something to tackle as a new member Workoad Light A few simple changes labels Oct 25, 2024
@adamseth2 adamseth2 added the Medium Priority Worth working on label Nov 8, 2024
@Quashnock Quashnock linked a pull request Nov 16, 2024 that will close this issue
@adamseth2
Copy link
Collaborator Author

Reopening because PR automatically closes the issue (usually fine but this had 2 parts). Latency needs to be implemented still. Will require recoding heartbeat.

@adamseth2 adamseth2 reopened this Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Something to tackle as a new member Medium Priority Worth working on Workoad Light A few simple changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants