Clean up error handling in compute_secrets #95
+117
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngPrivateShares DkgError; add TryFromInt DkgError and remove unwrap call in compute_secret; clean up tests
…g API breaking changes anyway
…n't have to worry about getting anything other than bad private shares from compute secrets
xoloki
commented
Nov 21, 2024
djordon
reviewed
Nov 21, 2024
…ugh we checked above that the keys should be present
djordon
reviewed
Nov 22, 2024
Comment on lines
-136
to
-138
| if shares.len() != polys.len() { | ||
| return Err(DkgError::NotEnoughShares(vec![self.id])); | ||
| } |
There was a problem hiding this comment.
Do we need an equivalent check for this?
There was a problem hiding this comment.
The MissingPrivateShares check covers this case, and also provides more information.
There was a problem hiding this comment.
Hmmm, I think it covers one case, but what if private_shares is longer than public_shares? I imaging that case is caught elsewhere?
There was a problem hiding this comment.
I’d argue that we aren’t considering that an error anymore, since it doesn’t stop us from computing the secrets.
Maybe log a warning?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error handling in
compute_secrethas always been problematic. This PR cleans it up, checking for the same errors inv1andv2.One issue is that if there is any non-overlap between public and private shares, we didn't have a good way to determine which should be treated as canonical. But the network state machines give a good hint; since
DkgEngBeginwill specify which are the signers taking part, we should expect to have exactly thoseDkgPublicShares.Since we're making API breaking changes to the errors, I also added
TryFromIntvariants toDkgErrorandAggregatorErrorand used them to remove mostunwrapcalls fromv1andv2.Fixes #47 and addresses #89