Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ME-02 Duplicated Method Calls Could Lead to Denial of Service #72

Open
xoloki opened this issue May 8, 2024 · 1 comment
Open

ME-02 Duplicated Method Calls Could Lead to Denial of Service #72

xoloki opened this issue May 8, 2024 · 1 comment
Assignees
Labels

Comments

@xoloki
Copy link
Collaborator

xoloki commented May 8, 2024

Coordinator methods accepting signers shares and nonces, as well as signer methods
accepting shares and nonces do not check if said values have already been received
correctly. A malicious signer, for instance, could repeatedly send the same public shares
before the coordinator is able to process the public shares from other signers and in this
way put a high burden on the coordinator who could not possibly process all messages in
time and therefore stall without moving to the next stage. Moreover, older values are
overwritten and this could lead to signers losing track of what the valid values are.

@xoloki xoloki added the audit label May 8, 2024
@xoloki xoloki self-assigned this May 8, 2024
@xoloki
Copy link
Collaborator Author

xoloki commented Nov 21, 2024

sBTC at one point had a networking bug where it duplicated messages. This did in fact lead to problems, so this bug should be fixed ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant