Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting to turn off torch glow. #26

Open
BleuFaux opened this issue Apr 11, 2024 · 3 comments
Open

Setting to turn off torch glow. #26

BleuFaux opened this issue Apr 11, 2024 · 3 comments
Assignees
Labels
enhancement Changes for an existing feature

Comments

@BleuFaux
Copy link

Is your suggested enhancement related to a problem? Please describe.

The current implementation of the hand-held torch lighting flickers as you walk. It's subtle but is bothersome, I realize this may not be fixable, but my shader already does the same thing without the flicker, so I would like to be able to turn this specific feature off.

Describe the solution you'd like

I would like a setting in the config file/menu to be able to specifically turn the hand-held torch lighting feature on and off.

Describe alternatives you've considered

No response

Additional context

No response

@BleuFaux BleuFaux added the enhancement Changes for an existing feature label Apr 11, 2024
@Tschipcraft
Copy link
Owner

Thank you for the suggestion. Does this only specifically apply to holding a torch or other items/other locations like a torch item as well?

@Tschipcraft Tschipcraft added the question Further information is requested label Apr 14, 2024
@BleuFaux
Copy link
Author

Hmm, so in the case of the shader, it seems to only work on the torch and the lantern. So for my personal use it would only need to be those two BUT, that may not be the case for all shaders. I guess one option is to turn it off for anything being held by the player. Or maybe just the two major items, torches and lanterns, but allow it for items you have added light too? I think 99% of the time the issue will be related to just torches held by the player though.

@Tschipcraft
Copy link
Owner

Alright, I'll see what I can do

@Tschipcraft Tschipcraft removed the question Further information is requested label Apr 20, 2024
@Tschipcraft Tschipcraft self-assigned this Apr 20, 2024
Tschipcraft added a commit that referenced this issue Sep 9, 2024
Added per-player toggle for Dynamic Lights (closes #37, #26, #47)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Changes for an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants