Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor tests into multiple Github CI steps #2179

Closed
yebai opened this issue Mar 11, 2024 · 4 comments
Closed

refactor tests into multiple Github CI steps #2179

yebai opened this issue Mar 11, 2024 · 4 comments
Assignees

Comments

@yebai
Copy link
Member

yebai commented Mar 11, 2024

Similiar to TuringLang/JuliaBUGS.jl#149.

Let's remove the complex macros including numerical_testset, and turing_testset etc. Instead, let's simply group tests by files and run these test files in different CI runners.

Useful resource for local test: https://gist.github.com/torfjelde/62c1281d5fc486d3a404e5de6cf285d4

@yebai
Copy link
Member Author

yebai commented May 15, 2024

For HMC sampling correctness, we only need to test against one AD backend, but we currently test against a few.

We only need to test gradient evaluation for the AD functionality test, but we currently run HMC, which is an overkill.

@torfjelde
Copy link
Member

Very much agree with this 👍

@torfjelde
Copy link
Member

We only need to test gradient evaluation for the AD functionality test, but we currently run HMC, which is an overkill.

A counter point to this: TuringLang/DynamicPPL.jl#612

Sometimes AD only breaks when we're sampling 😬

@mhauru mhauru self-assigned this May 21, 2024
@yebai
Copy link
Member Author

yebai commented Jun 5, 2024

Fixed by #2237

@yebai yebai closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants