Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show_progress_bar estimated time not accurate when dataset has texts of varying lengths #2940

Open
cdfox opened this issue Sep 16, 2024 · 0 comments

Comments

@cdfox
Copy link

cdfox commented Sep 16, 2024

Due to encode() sorting the sentences in decreasing order by length, if I pass in a large list of texts with large variation in length (I'm using a model that supports up to 8192 max_seq_length, but most of the texts are much shorter than that), the initial estimate of time remaining from tqdm is way too high (e.g., 4 hours instead of 30 minutes). Perhaps when show_progress_bar=True, it would be good to print a warning that the time remaining may be overestimated due to the sort order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant