Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate TF topics for mocap and pose logging #572

Open
whoenig opened this issue Dec 22, 2021 · 1 comment
Open

Separate TF topics for mocap and pose logging #572

whoenig opened this issue Dec 22, 2021 · 1 comment

Comments

@whoenig
Copy link
Contributor

whoenig commented Dec 22, 2021

Currently we use the same TF topic for the mocap data and pose logging. This can cause jitter in rviz, see #566. Ideally, we would switch to separate frame names to avoid confusion.

@jpreiss
Copy link
Collaborator

jpreiss commented Dec 22, 2021

You mentioned in #566:

This [jitter] should have no effect on correct operation, since tf is only used for visualization purposes, not for actual computations.

I agree that is true for the Crazyswarm internally, but user scripts could be broken if they use Crazyflie.position() for computations, yes?

What if we do something like

Sources Available tf world pose topic
mocap only mocap N/A
mocap and onboard mocap onboard
onboard only onboard onboard

The pose topic always represents the onboard estimate (if logged) and the tf relative to world represents the best available pose estimate. Most scripts can continue using cf.position() oblivious to its source, while only those scripts comparing onboard estimates to "ground truth" need to do something special.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants