Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kilometers Per Hour #472

Open
ItalicIntegral opened this issue Apr 10, 2024 · 3 comments
Open

Kilometers Per Hour #472

ItalicIntegral opened this issue Apr 10, 2024 · 3 comments

Comments

@ItalicIntegral
Copy link

Good day,

I noticed that we have a checkbox to change from M/S to MPH. Would it be possible to add Km/h?

@fossfreedom
Copy link
Member

This is for the weather applet? The windspeed calculation is here -

Happy to receive a suitable pull-request.

@Jacob-Vlijm
Copy link
Member

Jacob-Vlijm commented Apr 11, 2024

Maybe better show the two at once then, like:
10m/s (36 km/h)
Saves another checbox.

@ItalicIntegral
Copy link
Author

I don't think making the field multi-unit is a good idea. I believe that the field should be a dropdown and not a check box. Furthermore, the unit that one is seeking depends on location and possibly on profession. The meter per second M/S is the SI unit recommended by the World Meteorological Society and is used in Nordic countries so I would make it the default. However, other units such as Km/h, MPH, ft/s, knots, and Beaufort are also used by some. We probably don't need to get fancy with historical units like Beaufort but the others can be directly derived from the SI unit.

I'm not a programmer. I did look through the code but I'm not even sure how to make a pull request is otherwise I would help.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants