Skip to content
This repository has been archived by the owner on Apr 25, 2024. It is now read-only.

Can Fraction be moved to separate package? #13

Open
shrpne opened this issue Oct 14, 2021 · 2 comments
Open

Can Fraction be moved to separate package? #13

shrpne opened this issue Oct 14, 2021 · 2 comments
Labels
enhancement New feature or request p2 Low Priority

Comments

@shrpne
Copy link

shrpne commented Oct 14, 2021

I very like Fraction implementation and would like to use it in my project, but for now i have to install whole sdk-core which pulls ethersproject and other unrelated dependencies.

Can it be moved to a separate package?

@marktoda marktoda added enhancement New feature or request p2 Low Priority labels Jul 6, 2022
@marktoda
Copy link
Contributor

marktoda commented Jul 6, 2022

Hi @shrpne! Thanks for requesting this, I can definitely see the Fraction package being useful on its own. Given this codebase is licensed under MIT, feel welcome to pull it into a separate package as long as you follow the license guidelines.

If you do so, it'd be great if you submitted a PR to the README here pointing to the separate package for others who might also like the Fraction package on its own.

@hiroshitashir
Copy link

A separate package was created at https://github.com/hiroshitash/uniswap-sdk-fraction.
A PR for the README was also created.

Please let me know with any questions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request p2 Low Priority
Projects
Development

No branches or pull requests

3 participants