chore: update build on dotnet to use release artifacts #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sighphyre
commented
Oct 30, 2024
| cd dotnet-engine | ||
| version=${{ github.event.inputs.version }} | ||
| sed -i "s/<Version>.*<\/Version>/<Version>$version<\/Version>/" Yggdrasil.Engine/Yggdrasil.Engine.csproj | ||
| binaries=("libyggdrasilffi_aarch64.so linux/aarch64/libyggdrasilffi.so" |
There was a problem hiding this comment.
Would love to have this list of binaries defined in one place across all builds but I can't see an obvious and sane way to do that right now
For the .NET case, we also have to put the binaries in specific locations, which makes this more challenging to abstract
Open to suggestions, but I'll probably do that in a future PR
sighphyre
commented
Oct 30, 2024
| dotnet restore dotnet-engine.sln | ||
| sudo apt-get install -y xmlstarlet | ||
| cd dotnet-engine/Yggdrasil.Engine | ||
| CORE_VERSION=$(xmlstarlet sel -t -v "/Project/PropertyGroup/YggdrasilCoreVersion" -n Yggdrasil.Engine.csproj) |
There was a problem hiding this comment.
Dirty little cheat to pull the version property for Ygg out the raw XML, because apparently msbuild doesn't give you an option to do that from the command line #sad
sighphyre
changed the title
sighphyre
force-pushed
the
chore/update-build-on-dotnet
branch
4 times, most recently
from
8996fde
to
0a71087
Compare
sighphyre
force-pushed
the
chore/update-build-on-dotnet
branch
from
0a71087
to
afdfb6e
Compare
sighphyre
force-pushed
the
chore/update-build-on-dotnet
branch
from
bb31b0c
to
526273d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binary build is now handled by a completely different task that's fired on
cargo smart-release(or just pushing a tag, but don't do that).The .NET build now picks up the binaries from the release artifacts, and uses an internal property - YggdrasilCoreVersion in its build files to set the version of Yggdrasil FFI that will be used. This means that our versioning is now tracked in source control