Better typing on Binding

[SylvanFranklin]

#[derive(Deserialize, Debug)]
pub struct Binding {
    pub key: Option<String>,
    pub arrow: Option<Arrow>,
    // TODO: Make this optional,
    pub modifiers: Vec<String>,
    pub command: String,
}

I think there should be a dedicated struct for modifiers that has Options for each kind of command. It would make debugging and providing error messages a lot more clear.

[SylvanFranklin]

It might also be worth adding a third party crate that handles types for keyboard input.

[Uzaaft]

It might also be worth adding a third party crate that handles types for keyboard input.

In general, I'd like to try and avoid pulling in a third party crate for something so simple.

[Uzaaft]

I think there should be a dedicated struct for modifiers that has Options for each kind of command. It would make debugging and providing error messages a lot more clear.

I like the idea of this. Would make debugging, as well as logging so much better.

[Uzaaft]

We do have use: https://docs.rs/global-hotkey/0.6.0/global_hotkey/
It has both Modifiers and normal keys. Isn't that sufficient?

[SylvanFranklin]

Oh yes sorry I didn't look into the dependencies that closely, that's perfect.

[Uzaaft]

Working on this in an upcoming coming breaking change which will remove the toml config.