Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BeckstromResearch #513

Closed
chrisbeckstrom opened this issue Sep 24, 2018 · 6 comments
Closed

BeckstromResearch #513

chrisbeckstrom opened this issue Sep 24, 2018 · 6 comments
Labels

Comments

@chrisbeckstrom
Copy link

plugin name: Beckstrom Research
slug name: BeckstromResearch
Repository: https://github.com/chrisbeckstrom/Beckstrom_Research_Rack
email address: chris@chrisbeckstrom.com

@mdemanett
Copy link
Contributor

Hey @chrisbeckstrom,

I added this to the system, which means it'll be queued to build and send out through the plugin manager.

However you should make a fix: you don't want to check your .o, .so and .dylib files into git...these should be built by whoever uses the code (like the build system for the plugin manager). Something like git rm -rf build/* plugin.so plugin.dylib, and then commit and push, will take care of it.

@cschol
Copy link
Collaborator

cschol commented Sep 24, 2018

@chrisbeckstrom you also will need to remove those binaries from the HISTORY of the repository. See this link for more information on how to remove files from the repository history.

chrisbeckstrom pushed a commit to chrisbeckstrom/Beckstrom_Research_Rack that referenced this issue Sep 25, 2018
chrisbeckstrom pushed a commit to chrisbeckstrom/Beckstrom_Research_Rack that referenced this issue Sep 25, 2018
@chrisbeckstrom
Copy link
Author

chrisbeckstrom commented Sep 25, 2018

Thanks @mdemanett and @cschol ! I think I have a lot to learn, thanks for helping me with this.
I removed those unnecessary files, then purged them from git (I hope!).
Am I correct in understanding that

it'll be queued to build and send out through the plugin manager .

...means that at some point in the future, folks will be able to add my plugins via the plugin manager and have them automatically added to their plugins folder on their local machine? I.e. they won't have to build anything, the files will just appear and be ready to use

@cschol
Copy link
Collaborator

cschol commented Sep 25, 2018

Sorry, this is not quite enough yet, as the files are still in the HISTORY of the repository, i.e. I can check out an earlier revision of the repo and the files are back.

See the steps in this issue chrisbeckstrom/Beckstrom_Research_Rack#7 to resolve it.

@AndrewBelt
Copy link
Member

It's not a huge issue because it's probably only a MB or two, but it does add up. We just don't want a recursive checkout to take up 20GB of space.

@AndrewBelt
Copy link
Member

Updated build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants