Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: onnxruntime 1.17.0をビルドできるように #36

Merged
merged 13 commits into from
Feb 6, 2024

Conversation

sevenc-nanashi
Copy link
Member

@sevenc-nanashi sevenc-nanashi commented Feb 3, 2024

内容

onnxruntime 0.17.0をビルドできるようにします。

関連 Issue

スクリーンショット・動画など

(なし)

その他

サンプル: https://github.com/sevenc-nanashi/onnxruntime-builder/actions/runs/7768024146

@sevenc-nanashi sevenc-nanashi marked this pull request as ready for review February 3, 2024 17:15
@sevenc-nanashi
Copy link
Member Author

多分良さそうなのでDraft外しました

@sevenc-nanashi
Copy link
Member Author

cc: @stakemura

Copy link
Contributor

@stakemura stakemura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです。ご対応感謝します!

Copy link
Member

@qryxip qryxip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM。ortもmainブランチでは1.17.0に上がったので、voicevox_core#725で試せると思います。
(まだ試してませんが)

@qryxip qryxip changed the title Fix: onnxruntime 0.17.0をビルドできるように Fix: onnxruntime 1.17.0をビルドできるように Feb 4, 2024
@qryxip
Copy link
Member

qryxip commented Feb 4, 2024

PRタイトルだけ修正させて頂きました...

@qryxip qryxip requested a review from Hiroshiba February 4, 2024 07:54
1_17_patch.patch Outdated Show resolved Hide resolved
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

ビルドしてみます!

@Hiroshiba Hiroshiba merged commit 27fe9f0 into VOICEVOX:main Feb 6, 2024
@qryxip qryxip mentioned this pull request Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ONNX Runtime 1.17.0対応
4 participants