Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR時に走るworkflowの数を減らす #382

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/build_and_deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,12 @@ on:
types:
- published
pull_request:
paths:
- '**.rs'
- '**.toml'
y-chan marked this conversation as resolved.
Show resolved Hide resolved
push:
branches:
- "*"
- "**/*"
branches:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
branches:
branches:

- main
env:
# releaseタグ名か、workflow_dispatchでのバージョン名か、DEBUGが入る
VERSION: ${{ github.event.release.tag_name || github.event.inputs.version || 'DEBUG' }}
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/cargo-deny.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
name: cargo-deny
on:
push:
branches:
- main
pull_request:
paths:
- '**.toml'
y-chan marked this conversation as resolved.
Show resolved Hide resolved
jobs:
cargo-deny:
runs-on: ubuntu-20.04
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/generate_document.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ on:
branches:
- main
pull_request:
paths:
- '**.rs'
y-chan marked this conversation as resolved.
Show resolved Hide resolved
jobs:
generate_api_document:
runs-on: ubuntu-latest
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/test.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build_cpp_example.ymlに分離したbuild-unix-cpp-exampleがまだ残っています。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

指摘ありがとうございます!

昨日の時点で気づいてはいて、ローカルでは直しています。あとで他の変更と一緒にまとめてpushするつもりでした

Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
name: test workflow
on:
push:
branches:
- "*"
- "**/*"
branches:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
branches:
branches:

- main
pull_request:
jobs:
shellcheck:
Expand Down