Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
commented
Aug 2, 2023
Comment on lines
-29
to
-31
| branches: | ||
| - "*" | ||
| - "**/*" |
There was a problem hiding this comment.
これが書かれているとこと書かれてないとこがあったので、書かない方針の方に統一してみました。
|
build_and_deploy.ymlを実行したら勝手にbulid_and_deploy_downloader.ymlも実行するようにしようかなと思ったのですが、トリガーがよくわかんないことになっちゃうのと（workflow_dispatchとworkflow_callで同じ引数群を定義しないといけない）、エンジンの方はdocker buildを別で実行しているのでこっちもその形にしようかなと思います。。 |
|
レビューありがとうございます！！ マージします！！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
関連タスク。
ダウンローダーがいつでも５並列でビルドされていて、各々5分くらいかかっていたので削減します。
関連 Issue
ref #382
その他
precompiledとなっていたのですが、そういう案内をしていたのはここのyamlファイルだけあったので削除しました。あと改行が全くなくてかなり読みづらかったので改行してみました。