chore: minor refactor #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qryxip
commented
Sep 19, 2024
Comment on lines
-86
to
-92
| /* | ||
| * Cの関数として公開するための型や関数を定義するこれらの実装はvoicevox_core/publish.rsに定義してある対応する関数にある | ||
| * この関数ではvoicevox_core/publish.rsにある対応する関数の呼び出しと、その戻り値をCの形式に変換する処理のみとする | ||
| * これはC文脈の処理と実装をわけるためと、内部実装の変更がAPIに影響を与えにくくするためである | ||
| * voicevox_core/publish.rsにある対応する関数とはこのファイルに定義してある公開関数からvoicevoxプレフィックスを取り除いた名前の関数である | ||
| */ | ||
|
|
There was a problem hiding this comment.
代わりの文面が思い付かなかったので、役割を終えたということで丸ごと削除。
qryxip
commented
Sep 19, 2024
qryxip
commented
Sep 19, 2024
There was a problem hiding this comment.
なんだったっけこのファイルの役割…？ blameしてもよくわからない。
There was a problem hiding this comment.
importできるかのチェック･･････････････････？
conftest側をimportしているのはちょっと理由わからないですが。。。。
Hiroshiba
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
単体でPRを出すには微妙な、細かいリファクタです。
主に不要なコードの削除と、嘘コメントの訂正です。diffの範囲が大きくなりそうなやつは見送りました。
関連 Issue
その他