change: minor changes for UserDict API
#835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qryxip
changed the title
UserDict api
qryxip
changed the title
UserDict apiUserDict API
Hiroshiba
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
UserDictのパブリックAPIについて以下の変更を加えます。loadとstoreが引数に取るファイルパスについて:&strからimpl AsRef<Path>にするStrPath相当にするjava.io.Fileとjava.nio.file.Pathのオーバーロードを追加するwith_wordsから&mut IndexMap<…>が得られるようにします。関連 Issue
その他
本当は
dictやjava.util.HashMapへ変換するやつについても手を入れたかったのですが、やるならそこそこ大々的にやった方がよいかなと思い見送りました。