Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression - Uninitialized geiger counter volume variable assertion on Debug builds #3856

Open
JoelTroch opened this issue Oct 18, 2024 · 0 comments

Comments

@JoelTroch
Copy link
Contributor

Back in 2014, PR #1539 was merged to fix several assertion issues on Debug builds about uninitialized variables.

However, the first HL25 update commit (0fc8913#diff-9203423ac932f9aa4e788c44e510c924891af4ba2f6453abdf028a24add6d412) seems to have reverted that change in the geiger (cl_dll/geiger.cpp) volume (flVol variable in CHudGeiger::Draw(float flTime)) thus bringing back that assertion issue.

This can be easily fixed by reverting the (accidental ?) change from the mentioned HL25 update commit and making sure the concerned code works like the already merged PR.

JoelTroch added a commit to JoelTroch/halflife-updated that referenced this issue Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant