Feature/42a inaccurate fdpm amplitude and phase derivative values with respect to mu a and mu s #54
Conversation
…tests passing. Results seem reasonable. More check out is needed though.
…mplexDerivativeDataPoint.
…'s results posted Jan 14 on Issue #42
…phase-derivative-values-with-respect-to-mu_a-and-mu_s
…dded PlotViewModel test.
…mments in PlotViewModel.
|
I have fixed the code coverage percentage to 93.3% and now passes. I think the checks are not passing due to the new issues. I will work on those this week. The code can be tried at this point though. I would like to make sure I didn't miss anything with regards to the derivatives if possible. |
|
The quality gate failed for this branch, there are 4 code smells, I think 2 can be easily fixed, once we do that we can reassess the quality gate to see if it still fails, if it does we might be able to change the parameters until we can clean up the code more. |
|
@lmalenfant, would you possibly be able to fix those code smells? If not, I can do later this week. |
|
@hayakawa16 It passed! I'll start reviewing the PR now :) |
|
Great work @lmalenfant! Thanks. |
|
@hayakawa16 when you get a chance, could you pull the latest and try out the log plots and let me know if this looks good to you. |
|
Hi @lmalenfant, I tried log plots both in x and y, and ticks look good. Are you still noticing something incorrect? |
|
@hayakawa16 I think everything looks good, I was running tests at the same time as running the GUI and I think that may have caused some issues. I tested several plots yesterday and they all looked good. |
… Updated the version number for the release.
|
Added the new VTS library and now I can get the Phase and Amplitude derivative values. Phase: Amplitude: |
|
hayakawa16
deleted the
feature/42a-inaccurate-fdpm-amplitude-and-phase-derivative-values-with-respect-to-mu_a-and-mu_s
branch
Draft of PR started so I can check code cleanup.