Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/61 Upgrade .NET to 8.0 #62

Merged
merged 1 commit into from
Sep 4, 2024
Merged

feature/61 Upgrade .NET to 8.0 #62

merged 1 commit into from
Sep 4, 2024

Conversation

lmalenfant
Copy link
Member

  • Upgraded to .NET 8.0 for Windows

@lmalenfant lmalenfant linked an issue Aug 21, 2024 that may be closed by this pull request
Upgrade .NET to 8.0 #61
Closed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 21, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

hayakawa16
hayakawa16 approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@hayakawa16 hayakawa16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I reviewed files changed, pulled changes, ran unit tests, and ran a few things on the GUI. Thumbs up!

@lmalenfant lmalenfant merged commit cc01434 into master Sep 4, 2024
2 checks passed
@lmalenfant lmalenfant deleted the feature/61-upgrade-dotnet-to-80 branch September 4, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hayakawa16 hayakawa16 hayakawa16 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade .NET to 8.0
2 participants
@lmalenfant @hayakawa16