Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/log nice floor #127

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Fix/log nice floor #127

merged 2 commits into from
Nov 15, 2023

Conversation

skie1997
Copy link
Contributor

@skie1997 skie1997 commented Nov 15, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Refactoring
  • Update dependency
  • Code style optimization
  • Test Case
  • Branch merge
  • Site / documentation update
  • Demo update
  • Workflow
  • Chore
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

log nice算法中,domain[0]如果使用Math.floor会出现domain[0] = dataMin的情况。而VChart中,log轴下柱状图的STACK_START = dataMin。
这种情况下柱状图中数据最小的值代表的柱子会不显示。
为了避免这个问题,将domain[0]改回原有逻辑,使其向下pow拓展。

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

copilot:summary

🔍 Walkthrough

copilot:walkthrough

@github-actions github-actions bot added the test label Nov 15, 2023
@xile611 xile611 merged commit fcf71e9 into main Nov 15, 2023
3 checks passed
@xile611 xile611 deleted the fix/log-nice-floor branch November 15, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants