-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
how to handle required_global_attributes
depending on activity_id
#11
Comments
I think it makes sense to rename it. CORDEX-CMIP6 is cumbersome, especially when said aloud. How about CORDEX6, in alignment with AR6 & CMIP6? |
actually, we discussed this in WCRP-CORDEX/cordex-cmip6-cv#5 . I think, there is some more or less convention to have the |
It has been decided to use "CORDEX-CMIP6" for this activity. Indeed, it's a bit cumbersome but provides good and clear description. From the CORDEX experiment design for dynamical downscaling of CMIP6 (https://cordex.org/wp-content/uploads/2021/05/CORDEX-CMIP6_exp_design_RCM.pdf): In addition to the continental-scale downscaling, addressed in this document, |
I'm not sure that there are build rules for the file name of the tables. Will the input4MIPs tables have the same names (without mip_era) as now for CMIP7? Other activities don't have their own table at all, e.g. ScenarioMIP etc. CORDEX is not a CMIP6 project or activity that contributes to CMIP6 and here we have more freedom to define what's better for CORDEX. Regarding Currently we have CORDEX_source_id.json assuming only RCMs as a source. However, when we are going to register ESD methods we need to distinguish this ESD source table from the RCM one, another level of complexity :-). Perhaps we may even need to add the CORDEX-CMIP6 |
@gnikulin - That makes sense. CORDEX-CMIP6 it is, then. With regard to |
I would include both limited area RCMs and VR-GCMs in the same "RCM" source_id file. There is the global attribute Regarding ML methods, I consider them as some kind of ESD and suggest to include them to the "ESD" source_id file. Information about datasets (e.g RCMs) used for training ML methods should be reflected in metadata (global attributes), can be different for the same ML method (e.g. https://cordex.org/wp-content/uploads/2017/06/CORDEX_ESD_Experiment1.pdf) Here, it is necessary to get input from the ESD community. Creating many CVs for specific cases may make the CORDEX data infrastructure too complex. I would vote for the simplest solution. |
Promoting specific values (RCM, ESD, ...) of the controlled vocabulary to the filenames seems to break the general build rules for these files. I see no problem in merging all source_id's under a single file, given that we add the (this thread has gone a bit off-topic from the original post) |
required_global_attributes
depending on activity_id
Yes, i agree that is sufficient to use For the required attributes to register a required global attributesI am unsure about the Second option would be to have another set of tables for bias adjustment and bias adjust based on the common CV in this repo. For example, for bias adjustment there would another repo of tables with the same filenames ( |
I would say different activities (see also WCRP-CORDEX/cordex-cmip6-cv#20) would need to define their own CV and tables, based on these general ones. It should be a matter of degenerating the CORDEX_activity_id.json to a single value, reducing other elements (e.g. CORDEX_domain_id.json) and generally adapting the rest of the elements (including the |
Yes, i agree with @jesusff, other activities might have different requirements for their vocabulary that we don't even know about yet. And from my experience, users will mess with the tables anyway. The important thing is to have a vocabulary that can be used for QA for ESGF publication, althoug we don't even have a checker yet 😣 (PrePARE does only work for CMIP6)
Thanks for opening WCRP-CORDEX/cordex-cmip6-cv#20 ! |
If we are back to the original post :-). Should we use CORDEX-CMIP6 for all tables and CVs instead of simply CORDEX ? My concern is that when we come to CORDEX-CMIP7 it's a bad practice to use the same file names for files with different content. |
OK, we can try to merge all source_id's under a single file and distinguish them by |
Does the
CORDEX-CMIP6 makes sense for exactly the reason you give, that we don't want ambiguity if/when we do this again later on. |
OK, agreed, i'll rename them! |
Regarding bias-adjusted variables, all modifications of their acronyms and long names are very simple and described in the DRS for bias-adjusted CORDEX simulations http://is-enes-data.github.io/CORDEX_adjust_drs.pdf by appending long names (the long_name NetCDF attribute) have to be also modified by adding There were no specific CORDEX-CMIP5 CMOR tables for bias-adjustment. |
Actually, there is no need to create new CMOR tables for different domains if output variable lists are different. All variables should be include in the CORDEX-CMIP6 CMOR tables and each domain post-processes only a subset of them. |
I agree, so maybe we can setup also a simple registration process for the data-request table (just give variable, frequency and some basic details) from which the tables are updated. |
Yes, it's a good idea. The atmospheric variable spreadsheet was the first human-readable step to discuss what variables should be archived. Adding new variables indeed can be done more efficiently with a registration process for the data request table. There is a ocean variable list (https://doi.org/10.5281/zenodo.8207553), again a spreadsheet :-), that should be included. |
OK, I can add the ocean variables, still have the script that can tackle the spreadsheets, seems to be similar format... |
The format should be the same as the atmospheric variable spreadsheet was used as a template. The ocean list published in zenodo is pdf but there is a goggle spreadsheet as well. |
There is also lists with aerosol variables (https://doi.org/10.5281/zenodo.7112860) and river ones (https://doi.org/10.5281/zenodo.7112673) should be checked to avoid duplication. |
That sounds like a good plan.
Is anyone up for abbreviating it to "CORDEX-6" for the sake of brevity?
…On 10/16/24 7:06 AM, Grigory Nikulin wrote:
Should we rename cordex to cordex-cmip6, both for the repository name
and for all CVs ? Many CVs are defined only for CORDEX-CMIP6 and will be
different in CORDEX-CMIP7.
—
Reply to this email directly, view it on GitHub <https://github.com/
WCRP-CORDEX/discuss#11>, or unsubscribe <https://github.com/
notifications/unsubscribe-auth/
AC5AZKMKOUNX6XNP3BA4X23Z3ZQHDAVCNFSM6AAAAABQBNYCL6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGU4TCOBTHE4DCMI>.
You are receiving this because you commented.Message ID: <WCRP-CORDEX/
***@***.***>
|
That was already discussed above (#11 (comment)) and generally discouraged. (this is an old issue that just came back to life when migrating it to a different repo) |
Should we rename cordex to cordex-cmip6, both for the repository name and for all CVs ? Many CVs are defined only for CORDEX-CMIP6 and will be different in CORDEX-CMIP7.
The text was updated successfully, but these errors were encountered: