Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] Can't access the SEC1 and ed25519 PubKey during read mode #159

Open
AyushBherwani1998 opened this issue Jun 21, 2024 · 3 comments
Open

Comments

@AyushBherwani1998
Copy link
Member

Description

Can't access the SEC1 and ed25519 PubKey when the requiredFactors are greater than 0, ideally we should allow them to read the pub key.

@metalurgical
Copy link
Contributor

This test passed, which shouldn't be reconstructing the key and should achieve the same result.

await t.test("#Get TSS Public Key", async function () {
     const coreKitInstance = newCoreKitInstance();

     await coreKitInstance.init({ handleRedirectResult: false });

     checkPubKey = coreKitInstance.getTssPublicKey();
});

Could you provide more information about how to reproduce this?

@AyushBherwani1998
Copy link
Member Author

I tried to access the getTssPublicKey when coreKitInstance.status was REQUIRED_SHARE which would be ideal case if someone had MFA enabled, and they did social login.

You can try to access the pub key here:

if (coreKitInstance.status === COREKIT_STATUS.REQUIRED_SHARE) {

I think in the test the MFA is not enabled, and it might be using default hased factor?

@metalurgical
Copy link
Contributor

metalurgical commented Jul 9, 2024

Have double checked this, in order to get the TSS public key tKey required reconstruction.

Have removed this check here:
tkey/tkey#290

Though for the ed25519 public key you might be looking for this method in tKey (doesn't appear to have any requirement on reconstruction), however the seed will obviously remain encrypted)?

    // core.ts
    getEd25519PublicKey()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants