Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with git dependencies #6

Open
Raynos opened this issue Feb 18, 2015 · 1 comment
Open

Does not work with git dependencies #6

Raynos opened this issue Feb 18, 2015 · 1 comment

Comments

@Raynos
Copy link
Contributor

Raynos commented Feb 18, 2015

I want to peer depend on a git dependency.

  "optionalPeerDependencies": {
    "foobar": "git+ssh://git@github.com:raynos/foobar#v6.0.0"
  }

It would be great if this supported git dependencies.

The best you can do in terms of correctness verification is assert that the absolute git link is the same for both the library that co depends and the application package.json

@ronkorving
Copy link
Collaborator

That sounds like a good idea. Thanks for the feedback. I'm recently very busy working on other stuff, so I'm not sure when I'll be able to get around to this. If you really need this, the best thing you can do is send in a PR. In the mean time, thanks again, and I'll leave this issue open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants