Skip to content
This repository has been archived by the owner on Jul 15, 2019. It is now read-only.

Navigation bar is not properly set for iPhone-X #43

Open
JigarPatel1234 opened this issue Sep 29, 2017 · 12 comments
Open

Navigation bar is not properly set for iPhone-X #43

JigarPatel1234 opened this issue Sep 29, 2017 · 12 comments

Comments

@JigarPatel1234
Copy link

I am using this control in my app and now for ios 11 iPhoneX i am facing problem in navigation bar as it is not properly used in iPhoneX simulator, so can it be possible to fix this issue. Thank you

@Sunbir
Copy link

Sunbir commented Sep 30, 2017

I see a similar issue with navigation spacing in general for ios 11. See attached screenshot:

simulator screen shot - iphone 6s - 2017-09-30 at 12 28 30

@drante
Copy link

drante commented Oct 6, 2017

@Sunbir Have you managed to solve this problem?

@Sunbir
Copy link

Sunbir commented Oct 6, 2017

Sorry, I haven't looked into it yet.

@ZZBHuang
Copy link
Contributor

It should be fixed on version 2.0.0

@drante
Copy link

drante commented Oct 14, 2017

@ZZBHuang I recently updated to version 2.0.0, but now the navigation bar has disappeared completely.
simulator screen shot - iphone 7 - 2017-10-15 at 01 51 09

@ZZBHuang
Copy link
Contributor

@drante Could you tell me your developing environment? Like Xcode version, target iOS version on simulator and reproduce flow. I've tried 2.0.0 on iPhone 8 simulator with Xcode 9.0 but got no luck to reproduce your issue. Thanks!

@drante
Copy link

drante commented Oct 15, 2017

@ZZBHuang Sure! :)

Xcode version: 9.0
iOS Deployment Target: 10.0

I tried a full reinstall of the pod but the problem still remained. Also, when presenting the image picker, I call present(imagePickerController, animated: true, completion: nil) instead of self.yms_presentCustomAlbumPhotoView(pickerViewController, delegate: self). Not sure if that has anything to do with this, but calling present() has worked fine until now.

@ZZBHuang
Copy link
Contributor

@drante Please use yms_presentCustomAlbumPhotoView instead because this version I'd added UINavigationController with YMSPhotoPickerViewController to display navigation bar. If you use present(imagePickerController, animated: true, completion: nil) then you cannot have the navigation bar supported. Thanks for your feedback!

@ZZBHuang
Copy link
Contributor

@JigarPatel1234 Please try 2.0.0 and close this issue if your problem solved :)

@rahulvyas
Copy link

rahulvyas commented May 16, 2018

I am also having the same issue on iPhone X.
I am using yms_presentCustomAlbumPhotoView method to show picker

@ZZBHuang
Copy link
Contributor

@rahulvyas Hi, does the demo app have the same problem on your iPhone X? You can enter bigger than 1 number to launch yms_presentCustomAlbumPhotoView on demo app.

@shrimp101
Copy link

I'm trying to install version 2.0.0 but it not success.
Please check my attachment

screen shot 2018-06-05 at 16 33 51
screen shot 2018-06-05 at 16 33 59

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants