You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As a user, I would not expect pvalueCutoff to be applied to the p.adjust column.
Or at least I think it should be made clear in the documentation that pvalueCutoff is not only applied to the pvalue column, but also the p.adjust column. In addition, given that we have always p.adjust >= pvalue, it might as well be documented as "adjusted pvalue cutoff".
That said, as an experienced R user and considering from the code that the only purpose of this cutoff value is to subset the result table, I would simply set pvalueCutoff=1 to get the full table and do the filtering myself.
I'm only reporting this unexpected behaviour for unsuspecting and less experienced users.
The text was updated successfully, but these errors were encountered:
https://github.com/GuangchuangYu/DOSE/blob/01913f001ad7ea0808a61e30f7f5943a84c3a23f/R/gsea.R#L57
As a user, I would not expect
pvalueCutoff
to be applied to thep.adjust
column.Or at least I think it should be made clear in the documentation that
pvalueCutoff
is not only applied to thepvalue
column, but also thep.adjust
column. In addition, given that we have alwaysp.adjust >= pvalue
, it might as well be documented as "adjusted pvalue cutoff".That said, as an experienced R user and considering from the code that the only purpose of this cutoff value is to subset the result table, I would simply set
pvalueCutoff=1
to get the full table and do the filtering myself.I'm only reporting this unexpected behaviour for unsuspecting and less experienced users.
The text was updated successfully, but these errors were encountered: