Send transaction in batches #1910
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsaction-messages
shawn-zil
reviewed
Nov 28, 2024
shawn-zil
reviewed
Nov 28, 2024
|
This adds some complexity in the mempool and node that makes me worry a bit. Before we decide on merging this, please could we do some testing to prove that batching |
…nsaction-messages
…ssages' of github.com:Zilliqa/zq2 into 1906-introduce-batching-mechanism-for-newtransaction-messages
…nsaction-messages
shawn-zil
reviewed
Dec 2, 2024
|
Last I recall, we were testing the difference this made in a test network. Did we get any results? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transactions are not immediately broadcast after being received from API but added to a new vector instead.
Mempool is regularly polled for anything in the batch and, if criteria is met (chosen arbitrarily), transactions are broadcast to other peers.
There's a new timer - the old one wasn't kicking out frequently (and if the traffic was stable - never).