You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When calling depositTopup() or withdraw(), we look up the validator's BLS key based on the validator controlAddress. However, we do not enforce uniqueness of the controlAddress. So we should either:
Demand that each validator has a unique controlAddress.
Add a blsPubKey parameter to depositTopup and withdraw and look up the validator based on that instead (and this means we can probably remove the _stakerKeys map)
I would prefer 2 since it makes the deposit contract simpler and means validator pools can use a single wallet to control many validators.
The text was updated successfully, but these errors were encountered:
Agreed that 2. would be best, the _stakerKeys map is confusing.
I assume it's purpose was to link the caller (msg.sender) to the data acted upon (stakerKey), so we should still do this check. @DrZoltanFazekas is that correct, was there any other intended use for _stakerKeys?
When calling
depositTopup()
orwithdraw()
, we look up the validator's BLS key based on the validatorcontrolAddress
. However, we do not enforce uniqueness of thecontrolAddress
. So we should either:controlAddress
.blsPubKey
parameter todepositTopup
andwithdraw
and look up the validator based on that instead (and this means we can probably remove the_stakerKeys
map)I would prefer 2 since it makes the deposit contract simpler and means validator pools can use a single wallet to control many validators.
The text was updated successfully, but these errors were encountered: