Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more curves #8

Open
ghost opened this issue Nov 3, 2021 · 2 comments
Open

Support more curves #8

ghost opened this issue Nov 3, 2021 · 2 comments

Comments

@ghost
Copy link

ghost commented Nov 3, 2021

This is an issue for the bolos family of crates, not the app itself

Currently in our bolos wrapper crate we only support 3 curves, while the full ledger SDK makes use of many more.

We need to define a design to encopass all these curves and also find a way to make it ergonomic to use in rust so that we can build apps more easily in the future.
We also need to actually implement bindings and methods to use these curves!

/cc @jleni @leongb @neithanmo

See
https://github.com/Zondax/ledger-tezos/blob/ef4425540c7425b359e4112c52e07f4520207765/rust/bolos-impl/src/crypto/ecfp256.rs#L148
https://github.com/Zondax/ledger-tezos/blob/ef4425540c7425b359e4112c52e07f4520207765/rust/bolos-impl/src/crypto/ecfp256.rs#L150
https://github.com/Zondax/ledger-tezos/blob/ef4425540c7425b359e4112c52e07f4520207765/rust/bolos-impl/src/crypto/ecfp256.rs#L39

🔗 zboto Link

@ghost ghost self-assigned this Nov 3, 2021
@ghost
Copy link
Author

ghost commented Nov 3, 2021

@ghost ghost transferred this issue from Zondax/ledger-tezos Nov 12, 2021
@jleni jleni unassigned ghost Jan 12, 2022
@jleni
Copy link
Member

jleni commented Jun 19, 2022

This has proven to be inflexible and too complicated. We should flatten a bit more the API and make it more similar to bolos instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant