Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] : Modernize build system #419

Open
baseplate-admin opened this issue Feb 26, 2023 · 2 comments
Open

[FEATURE REQUEST] : Modernize build system #419

baseplate-admin opened this issue Feb 26, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@baseplate-admin
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Hi there,
It seems that you guys use old python packaging format. It would be better should you guys move to a new build system ( eg: poetry and hatchling )

Describe the solution you'd like
move to hatchling or poetry.core.masonry.api

Describe alternatives you've considered
Keep old setuptools

Additional context
We can use something like

name: Release
on:
    release:
        types:
            - created

jobs:
    publish:
        strategy:
            fail-fast: false
            matrix:
                python-version: [3.11]
                poetry-version: [1.3.2]
                os: [ubuntu-latest]

        runs-on: ${{ matrix.os }}
        steps:
            - uses: actions/checkout@v2
            - uses: actions/setup-python@v2
              with:
                  python-version: ${{ matrix.python-version }}
            - name: Run image
              uses: abatilo/actions-poetry@v2.0.0
              with:
                  poetry-version: ${{ matrix.poetry-version }}
            - name: Publish
              env:
                  PYPI_TOKEN: ${{ secrets.PYPI_TOKEN }}
              run: |
                  poetry config pypi-token.pypi $PYPI_TOKEN
                  poetry publish --build

To automate the release process and since the entire python ecosystem is moving into using poetry build backends there will be more support

CC : @cullzie

@baseplate-admin baseplate-admin added the enhancement New feature or request label Feb 26, 2023
@cullzie
Copy link
Collaborator

cullzie commented Mar 7, 2023

Hey @baseplate-admin,
Yes this is something I have been trying to get around to doing for a long time.
I have already updated pyproject.toml to use poetry to build.
Just need to add in the actions to have it all done in a pipeline now

@baseplate-admin
Copy link
Contributor Author

Congratulations on moving to Poetry build ( the project needed it )

I can help with the actions part.. Let me see to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants