From 474a11dbb85d1bcaa60116bf26a9fa71b5078d42 Mon Sep 17 00:00:00 2001 From: bennibbelink <79653949+bennibbelink@users.noreply.github.com> Date: Wed, 8 May 2024 12:34:11 -0500 Subject: [PATCH 1/5] no longer require agnostic python in env instead of python3 --- INSTALL.rst | 6 +++--- README.rst | 2 +- cli/cycpp.py | 2 +- cli/cycstub | 2 +- cli/post-process-cython.py | 2 +- cmake/UseCython.cmake | 4 ++-- cyclus/CMakeLists.txt | 2 +- cyclus/gentypesystem.py | 2 +- cyclus/server.py | 6 +++--- docker/Dockerfile | 13 ++++++------- docker/Rocky.dockerfile | 14 ++++++-------- setup.py | 3 +-- share/CMakeLists.txt | 2 +- share/dbtypes_gen.py | 2 +- src/CMakeLists.txt | 14 +++++++------- src/hdf5_back_gen.py | 4 ++-- tests/CMakeLists.txt | 2 +- tests/test_stubs.py | 2 +- 18 files changed, 40 insertions(+), 44 deletions(-) diff --git a/INSTALL.rst b/INSTALL.rst index ca1c36903f..ce6aa89c8d 100644 --- a/INSTALL.rst +++ b/INSTALL.rst @@ -31,7 +31,7 @@ Run the install script: .. code-block:: bash - python install.py + python3 install.py If you successfully followed the instruction above, the cyclus binary has been generated and placed in the ``~/.local/`` in your home directory. @@ -47,7 +47,7 @@ On MacOSX you also need to add ~/.local/lib/pythonX.Y/site-packages to your .. code-block:: bash - echo "export PYTHONPATH=\"\$HOME/.local/lib/python`python -c 'import sys; \ + echo "export PYTHONPATH=\"\$HOME/.local/lib/python`python3 -c 'import sys; \ print(".".join(map(str, sys.version_info[:2])))'`/site-packages:\$PYTHONPATH\"" >> ~/.bashrc source ~/.bashrc @@ -128,7 +128,7 @@ installation flag. The otherwise identical process would look like: .. code-block:: bash - .../cyclus$ python install.py --coin_root=path/to/coin + .../cyclus$ python3 install.py --coin_root=path/to/coin CMake Cyclus Installation diff --git a/README.rst b/README.rst index 7bd23d1570..9d5c7c2451 100644 --- a/README.rst +++ b/README.rst @@ -134,7 +134,7 @@ simulations, first download Cycamore https://github.com/cyclus/cycamore.git``, - Install in the same location you installed Cyclus (eg. in ``~/.local/``): - ``python install.py`` from the ``cycamore`` folder. + ``python3 install.py`` from the ``cycamore`` folder. ************** diff --git a/cli/cycpp.py b/cli/cycpp.py index ed1f20208d..46103f93ba 100755 --- a/cli/cycpp.py +++ b/cli/cycpp.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 """The cyclus preprocessor. cycpp is a 3-pass preprocessor which adds reflection-like semantics to cyclus diff --git a/cli/cycstub b/cli/cycstub index d090a7fdad..898e8de4c7 100755 --- a/cli/cycstub +++ b/cli/cycstub @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 from __future__ import print_function diff --git a/cli/post-process-cython.py b/cli/post-process-cython.py index b1f6a375ce..645585390e 100755 --- a/cli/post-process-cython.py +++ b/cli/post-process-cython.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 from __future__ import print_function, unicode_literals import re diff --git a/cmake/UseCython.cmake b/cmake/UseCython.cmake index 122a815843..e75c0e9669 100644 --- a/cmake/UseCython.cmake +++ b/cmake/UseCython.cmake @@ -284,7 +284,7 @@ function( cython_add_standalone_executable _name ) set( other_module_sources "" ) set( main_module "" ) cmake_parse_arguments( cython_arguments "" "MAIN_MODULE" "" ${ARGN} ) - include_directories( ${PYTHON_INCLUDE_DIRS} ) + include_directories( ${Python3_INCLUDE_DIRS} ) foreach( _file ${cython_arguments_UNPARSED_ARGUMENTS} ) if( ${_file} MATCHES ".*\\.py[x]?$" ) get_filename_component( _file_we ${_file} NAME_WE ) @@ -310,5 +310,5 @@ function( cython_add_standalone_executable _name ) set( CYTHON_FLAGS ${CYTHON_FLAGS} --embed ) compile_pyx( "${main_module_we}_static" generated_file ${main_module} ) add_executable( ${_name} ${generated_file} ${pyx_module_sources} ${other_module_sources} ) - target_link_libraries( ${_name} ${PYTHON_LIBRARIES} ${pyx_module_libs} ) + target_link_libraries( ${_name} ${Python3_LIBRARIES} ${pyx_module_libs} ) endfunction() diff --git a/cyclus/CMakeLists.txt b/cyclus/CMakeLists.txt index 82edcfc88c..cf6009e025 100644 --- a/cyclus/CMakeLists.txt +++ b/cyclus/CMakeLists.txt @@ -8,7 +8,7 @@ INCLUDE_DIRECTORIES(${CYCLUS_CORE_INCLUDE_DIRS}) # First things first, code-generation # message(STATUS "Generating Type System API for Python") -EXECUTE_PROCESS(COMMAND python ${CMAKE_CURRENT_SOURCE_DIR}/gentypesystem.py +EXECUTE_PROCESS(COMMAND ${Python3_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/gentypesystem.py "--src-dir=${CMAKE_CURRENT_SOURCE_DIR}" "--data-model-version=${DATA_MODEL_VERSION}" "--verbose" diff --git a/cyclus/gentypesystem.py b/cyclus/gentypesystem.py index fab269e931..b794f16d5c 100644 --- a/cyclus/gentypesystem.py +++ b/cyclus/gentypesystem.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 """Generates Cyclus Type System bindings. Module history: diff --git a/cyclus/server.py b/cyclus/server.py index 8f650b50e5..f7545629f0 100644 --- a/cyclus/server.py +++ b/cyclus/server.py @@ -175,18 +175,18 @@ ====================== You may launch the cyclus server by running:: - $ python -m cyclus.server input.xml + $ python3 -m cyclus.server input.xml Most of the arguments are relatively self-explanatory. However, the CLI here also allows you to load initial and repeating actions. The syntax for this is an event name followed by parameter tokens (which must contain an equals sign):: - $ python -m cyclus.server input.xml --repeating-actions sleep n=1 + $ python3 -m cyclus.server input.xml --repeating-actions sleep n=1 You may load many actions by repeating the name-params pattern: - $ python -m cyclus.server input.xml --repeating-actions \ + $ python3 -m cyclus.server input.xml --repeating-actions \ sleep n=1 \ table_data table="TimeSeriesPower" diff --git a/docker/Dockerfile b/docker/Dockerfile index 2661659e46..b3a572b758 100644 --- a/docker/Dockerfile +++ b/docker/Dockerfile @@ -37,8 +37,7 @@ RUN apt update -y && apt install -y \ RUN apt install -y python3-pprintpp; exit 0 RUN apt clean -y all -RUN update-alternatives --install /usr/bin/python python /usr/bin/python3 10 -RUN mkdir -p `python -m site --user-site` +RUN mkdir -p `python3 -m site --user-site` FROM common-base as conda-deps @@ -91,7 +90,7 @@ RUN conda update -y --all && \ && \ mamba install -y --force-reinstall libsqlite && \ conda clean -y --all -RUN mkdir -p `python -m site --user-site` +RUN mkdir -p `python3 -m site --user-site` ENV CC /opt/conda/bin/x86_64-conda_cos6-linux-gnu-gcc ENV CXX /opt/conda/bin/x86_64-conda_cos6-linux-gnu-g++ ENV CPP /opt/conda/bin/x86_64-conda_cos6-linux-gnu-cpp @@ -110,12 +109,12 @@ ARG make_cores=2 COPY . /cyclus WORKDIR /cyclus -RUN python install.py -j ${make_cores} --allow-milps --code_coverage +RUN python3 install.py -j ${make_cores} --allow-milps --code_coverage ENV PATH /root/.local/bin:$PATH ENV LD_LIBRARY_PATH /root/.local/lib:/root/.local/lib/cyclus RUN lcov -c -d /cyclus -o initial_coverage.info --gcov-tool ${GCOV} --initial --no-external && \ cyclus_unit_tests && \ - cd tests && python -m pytest && cd .. && \ + cd tests && python3 -m pytest && cd .. && \ lcov -c -d /cyclus -o test_coverage.info --gcov-tool ${GCOV} --no-external && \ lcov --add-tracefile initial_coverage.info --add-tracefile test_coverage.info -o total_coverage.info && \ mkdir -p html && genhtml total_coverage.info --output-directory html @@ -135,7 +134,7 @@ WORKDIR /cyclus # You may add the option "--cmake-debug" to the following command # for further CMake debugging. -RUN python install.py -j ${make_cores} --allow-milps +RUN python3 install.py -j ${make_cores} --allow-milps ENV PATH /root/.local/bin:$PATH FROM cyclus as deb-generation @@ -151,4 +150,4 @@ RUN cyclus_unit_tests FROM cyclus-test as cyclus-pytest -RUN cd tests && python -m pytest +RUN cd tests && python3 -m pytest diff --git a/docker/Rocky.dockerfile b/docker/Rocky.dockerfile index 5056c8cf1a..e7298fc0ac 100644 --- a/docker/Rocky.dockerfile +++ b/docker/Rocky.dockerfile @@ -8,13 +8,11 @@ RUN dnf update -y && \ dnf install -y python3.11 epel-release FROM common-base as rocky-8-config -RUN alternatives --set python /usr/bin/python3.11 && \ - alternatives --set python3 /usr/bin/python3.11 && \ +RUN alternatives --set python3 /usr/bin/python3.11 && \ dnf config-manager --set-enabled powertools FROM common-base as rocky-9-config -RUN alternatives --install /usr/bin/python python /bin/python3.11 10 && \ - alternatives --install /usr/bin/python3 python3 /bin/python3.11 10 && \ +RUN alternatives --install /usr/bin/python3 python3 /bin/python3.11 10 && \ dnf config-manager --set-enabled crb FROM rocky-${rocky_version}-config as dnf-deps @@ -37,11 +35,11 @@ RUN dnf update -y && dnf install -y \ python3.11-pytest \ && dnf clean all -RUN mkdir -p $(python -m site --user-site) && python -m pip install pandas tables cython jinja2 +RUN mkdir -p $(python3 -m site --user-site) && python3 -m pip install pandas tables cython jinja2 FROM dnf-deps as libxmlpp RUN dnf update -y && dnf install -y wget m4 doxygen perl-open perl-XML-Parser diffutils pcre-cpp pcre-devel && \ - python -m pip install meson ninja packaging && \ + python3 -m pip install meson ninja packaging && \ wget https://github.com/libxmlplusplus/libxmlplusplus/releases/download/4.0.3/libxml++-4.0.3.tar.xz && \ tar xf libxml++-4.0.3.tar.xz && \ cd libxml++-4.0.3 && \ @@ -72,7 +70,7 @@ WORKDIR /cyclus # You may add the option "--cmake-debug" to the following command # for further CMake debugging. -RUN python install.py -j ${make_cores} -D Python3_EXECUTABLE=/usr/bin/python3.11 +RUN python3 install.py -j ${make_cores} -D Python3_EXECUTABLE=/usr/bin/python3.11 ENV PATH /root/.local/bin:$PATH ENV LD_LIBRARY_PATH /root/.local/lib:/root/.local/lib/cyclus @@ -82,5 +80,5 @@ RUN cyclus_unit_tests FROM cyclus-test as cyclus-pytest -RUN cd tests && python -m pytest +RUN cd tests && python3 -m pytest diff --git a/setup.py b/setup.py index 32cd3de4ad..66fac232e1 100644 --- a/setup.py +++ b/setup.py @@ -57,8 +57,7 @@ def run_setup(ver): url='http://fuelcycle.org', platforms=['posix'], classifiers=['Operating System :: POSIX', - 'Programming Language :: Python :: 3', - 'Programming Language :: Python :: 2'], + 'Programming Language :: Python :: 3'], packages=['cyclus'], package_dir={'cyclus': 'cyclus'}, package_data={'cyclus': ['*.pxd', '*.so', '*.dylib']}, diff --git a/share/CMakeLists.txt b/share/CMakeLists.txt index 9902efa71b..91f3ada347 100644 --- a/share/CMakeLists.txt +++ b/share/CMakeLists.txt @@ -20,7 +20,7 @@ CONFIGURE_FILE( COPYONLY ) -EXECUTE_PROCESS(COMMAND python ${CMAKE_CURRENT_SOURCE_DIR}/dbtypes_gen.py ${DATA_MODEL_VERSION} OUTPUT_VARIABLE DBTYPES_JSON_ENTRIES RESULT_VARIABLE res_var) +EXECUTE_PROCESS(COMMAND ${Python3_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/dbtypes_gen.py ${DATA_MODEL_VERSION} OUTPUT_VARIABLE DBTYPES_JSON_ENTRIES RESULT_VARIABLE res_var) IF(NOT "${res_var}" STREQUAL "0") message(FATAL_ERROR "Process dbtypes_gen.py failed, res_var = '${res_var}'") ENDIF() diff --git a/share/dbtypes_gen.py b/share/dbtypes_gen.py index 09c628bca8..ed75fd5aff 100644 --- a/share/dbtypes_gen.py +++ b/share/dbtypes_gen.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 from __future__ import print_function import os import re diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 19a2789a81..80f0afb3fa 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -48,37 +48,37 @@ copy_when_diff( "${CMAKE_CURRENT_SOURCE_DIR}/hdf5_back.h" ) -EXECUTE_PROCESS(COMMAND python ${CMAKE_CURRENT_SOURCE_DIR}/hdf5_back_gen.py "QUERY" OUTPUT_VARIABLE HDF5_BACK_CC_QUERY RESULT_VARIABLE res_var_q) +EXECUTE_PROCESS(COMMAND ${Python3_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/hdf5_back_gen.py "QUERY" OUTPUT_VARIABLE HDF5_BACK_CC_QUERY RESULT_VARIABLE res_var_q) IF(NOT "${res_var_q}" STREQUAL "0") message(FATAL_ERROR "Process hdf5_back_gen.py 'QUERY' failed, result = '${res_var_q}'") ENDIF() -EXECUTE_PROCESS(COMMAND python ${CMAKE_CURRENT_SOURCE_DIR}/hdf5_back_gen.py "CREATE" OUTPUT_VARIABLE HDF5_BACK_CC_CREATE RESULT_VARIABLE res_var_c) +EXECUTE_PROCESS(COMMAND ${Python3_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/hdf5_back_gen.py "CREATE" OUTPUT_VARIABLE HDF5_BACK_CC_CREATE RESULT_VARIABLE res_var_c) IF(NOT "${res_var_c}" STREQUAL "0") message(FATAL_ERROR "Process hdf5_back_gen.py 'CREATE' failed, result = '${res_var_c}'") ENDIF() -EXECUTE_PROCESS(COMMAND python ${CMAKE_CURRENT_SOURCE_DIR}/hdf5_back_gen.py "VL_DATASET" OUTPUT_VARIABLE HDF5_BACK_CC_VL_DATASET RESULT_VARIABLE res_var_v) +EXECUTE_PROCESS(COMMAND ${Python3_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/hdf5_back_gen.py "VL_DATASET" OUTPUT_VARIABLE HDF5_BACK_CC_VL_DATASET RESULT_VARIABLE res_var_v) IF(NOT "${res_var_v}" STREQUAL "0") message(FATAL_ERROR "Process hdf5_back_gen.py 'VL_DATASET' failed, result = '${res_var_v}'") ENDIF() -EXECUTE_PROCESS(COMMAND python ${CMAKE_CURRENT_SOURCE_DIR}/hdf5_back_gen.py "FILL_BUF" OUTPUT_VARIABLE HDF5_BACK_CC_FILL_BUF RESULT_VARIABLE res_var_f) +EXECUTE_PROCESS(COMMAND ${Python3_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/hdf5_back_gen.py "FILL_BUF" OUTPUT_VARIABLE HDF5_BACK_CC_FILL_BUF RESULT_VARIABLE res_var_f) IF(NOT "${res_var_f}" STREQUAL "0") message(FATAL_ERROR "Process hdf5_back_gen.py 'FILL_BUF' failed, result = '${res_var_f}'") ENDIF() -EXECUTE_PROCESS(COMMAND python ${CMAKE_CURRENT_SOURCE_DIR}/hdf5_back_gen.py "WRITE" OUTPUT_VARIABLE HDF5_BACK_CC_WRITE RESULT_VARIABLE res_var_w) +EXECUTE_PROCESS(COMMAND ${Python3_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/hdf5_back_gen.py "WRITE" OUTPUT_VARIABLE HDF5_BACK_CC_WRITE RESULT_VARIABLE res_var_w) IF(NOT "${res_var_w}" STREQUAL "0") message(FATAL_ERROR "Process hdf5_back_gen.py 'WRITE' failed, result = '${res_var_w}'") ENDIF() -EXECUTE_PROCESS(COMMAND python ${CMAKE_CURRENT_SOURCE_DIR}/hdf5_back_gen.py "VAL_TO_BUF" OUTPUT_VARIABLE HDF5_BACK_CC_VAL_TO_BUF RESULT_VARIABLE res_var_vb) +EXECUTE_PROCESS(COMMAND ${Python3_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/hdf5_back_gen.py "VAL_TO_BUF" OUTPUT_VARIABLE HDF5_BACK_CC_VAL_TO_BUF RESULT_VARIABLE res_var_vb) IF(NOT "${res_var_vb}" STREQUAL "0") message(FATAL_ERROR "Process hdf5_back_gen.py 'VAL_TO_BUF' failed, result = '${res_var_vb}'") ENDIF() -EXECUTE_PROCESS(COMMAND python ${CMAKE_CURRENT_SOURCE_DIR}/hdf5_back_gen.py "BUF_TO_VAL" OUTPUT_VARIABLE HDF5_BACK_CC_BUF_TO_VAL RESULT_VARIABLE res_var_bv) +EXECUTE_PROCESS(COMMAND ${Python3_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/hdf5_back_gen.py "BUF_TO_VAL" OUTPUT_VARIABLE HDF5_BACK_CC_BUF_TO_VAL RESULT_VARIABLE res_var_bv) IF(NOT "${res_var_bv}" STREQUAL "0") message(FATAL_ERROR "Process hdf5_back_gen.py 'BUF_TO_VAL' failed, result = '${res_var_bv}'") ENDIF() diff --git a/src/hdf5_back_gen.py b/src/hdf5_back_gen.py index 04875905ef..5d4c0592db 100644 --- a/src/hdf5_back_gen.py +++ b/src/hdf5_back_gen.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 """This module generates HDF5 backend code found in src/hdf5_back.cc There are 8 distinct code generation options, one of which must be passed @@ -14,7 +14,7 @@ ------- To generate the code found in src/hdf5_back.cc::Query, use - $ python hdf5_back_gen.py QUERY + $ python3 hdf5_back_gen.py QUERY """ import os diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt index 2826f7a983..eb6138bf28 100644 --- a/tests/CMakeLists.txt +++ b/tests/CMakeLists.txt @@ -95,7 +95,7 @@ set(tgt "cyclus_unit_tests") add_custom_target( ${tgt}-post-build DEPENDS ${tgt} - COMMAND python "${CMAKE_CURRENT_SOURCE_DIR}/generate_gtest_macros.py" + COMMAND ${Python3_EXECUTABLE} "${CMAKE_CURRENT_SOURCE_DIR}/generate_gtest_macros.py" "--executable=${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/${tgt}" "--output=${CYCLUS_BINARY_DIR}/CTestTestfile.cmake" COMMENT "adding tests from ${tgt}" diff --git a/tests/test_stubs.py b/tests/test_stubs.py index a7675500ec..d94a6dd205 100644 --- a/tests/test_stubs.py +++ b/tests/test_stubs.py @@ -28,7 +28,7 @@ def test_stubs(): inst = os.path.join(d, 'baz') stub_cmd = 'cycstub --type {0} {1}:{1}:{2}' - inst_cmd = 'python install.py --build_dir {0} --prefix {1}' + inst_cmd = 'python3 install.py --build_dir {0} --prefix {1}' tst_cmd = './bin/{}_unit_tests' log = 'stub_test.log' From 75c978786df4c4463a5fdfd7614968993aa6a656 Mon Sep 17 00:00:00 2001 From: bennibbelink <79653949+bennibbelink@users.noreply.github.com> Date: Wed, 8 May 2024 12:44:57 -0500 Subject: [PATCH 2/5] update CHANGELOG --- CHANGELOG.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 22bb79a7ec..924081b9bd 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -10,6 +10,7 @@ Since last release **Changed:** * Changed README.rst installation instructions, tested on fresh Ubuntu-22.04 system with Python3.11 (#1744) +* Rely on `python3` in environment instead of `python` (#1747) **Removed:** From f2e4bbf554a64df93f9ea870609eacc816a58f69 Mon Sep 17 00:00:00 2001 From: bennibbelink <79653949+bennibbelink@users.noreply.github.com> Date: Wed, 8 May 2024 12:48:18 -0500 Subject: [PATCH 3/5] use Python3_EXECUTABLE for hdf5_back_gen.py --- src/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 80f0afb3fa..309370778a 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -33,7 +33,7 @@ CONFIGURE_FILE( @ONLY ) -EXECUTE_PROCESS(COMMAND python ${CMAKE_CURRENT_SOURCE_DIR}/hdf5_back_gen.py "VAL_TO_BUF_H" OUTPUT_VARIABLE HDF5_BACK_CC_VAL_TO_BUF_H RESULT_VARIABLE res_var_h) +EXECUTE_PROCESS(COMMAND ${Python3_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/hdf5_back_gen.py "VAL_TO_BUF_H" OUTPUT_VARIABLE HDF5_BACK_CC_VAL_TO_BUF_H RESULT_VARIABLE res_var_h) IF(NOT "${res_var_h}" STREQUAL "0") message(FATAL_ERROR "Process hdf5_back_gen.py 'VAL_TO_BUF_H' failed, result = '${res_var_h}'") ENDIF() From e0986050c90349d38f51bdfef4be8f6b1b89e156 Mon Sep 17 00:00:00 2001 From: bennibbelink <79653949+bennibbelink@users.noreply.github.com> Date: Wed, 8 May 2024 13:03:49 -0500 Subject: [PATCH 4/5] reference other PRs to show CI passing --- .github/workflows/build_test.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build_test.yml b/.github/workflows/build_test.yml index 937d1f30eb..0952277669 100644 --- a/.github/workflows/build_test.yml +++ b/.github/workflows/build_test.yml @@ -69,8 +69,9 @@ jobs: if: ${{ github.event_name == 'pull_request' && steps.build-cyclus.outcome == 'success' }} uses: actions/checkout@v4 with: - repository: cyclus/cycamore + repository: bennibbelink/cycamore path: ${{ github.workspace }}/cycamore + ref: python3 - name: Build and Test Cycamore id: build-cycamore @@ -93,8 +94,9 @@ jobs: if: ${{ github.event_name == 'pull_request' && steps.build-cycamore.outcome == 'success' }} uses: actions/checkout@v4 with: - repository: cyclus/cymetric + repository: bennibbelink/cymetric path: ${{ github.workspace }}/cymetric + ref: python3 - name: Build and Test Cymetric if: ${{ github.event_name == 'pull_request' && steps.build-cycamore.outcome == 'success' }} From c8a81967b0a4034e443617206db02078da19ea94 Mon Sep 17 00:00:00 2001 From: bennibbelink <79653949+bennibbelink@users.noreply.github.com> Date: Wed, 8 May 2024 13:07:28 -0500 Subject: [PATCH 5/5] reference correct repos/branches --- .github/workflows/build_test.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build_test.yml b/.github/workflows/build_test.yml index 0952277669..937d1f30eb 100644 --- a/.github/workflows/build_test.yml +++ b/.github/workflows/build_test.yml @@ -69,9 +69,8 @@ jobs: if: ${{ github.event_name == 'pull_request' && steps.build-cyclus.outcome == 'success' }} uses: actions/checkout@v4 with: - repository: bennibbelink/cycamore + repository: cyclus/cycamore path: ${{ github.workspace }}/cycamore - ref: python3 - name: Build and Test Cycamore id: build-cycamore @@ -94,9 +93,8 @@ jobs: if: ${{ github.event_name == 'pull_request' && steps.build-cycamore.outcome == 'success' }} uses: actions/checkout@v4 with: - repository: bennibbelink/cymetric + repository: cyclus/cymetric path: ${{ github.workspace }}/cymetric - ref: python3 - name: Build and Test Cymetric if: ${{ github.event_name == 'pull_request' && steps.build-cycamore.outcome == 'success' }}