Screenshot fileName has a period in the name when test suite is nested within another

[JaxxAnik]

Steps:
-Write a sample test and nest one describe within the other
-Write the nested test so it fails
EG:

describe('Suite1', () => {
  it('Random sample test', () => {
    expect(element(by.binding('latest')).getText()).toEqual('5');
  });
  describe('Suite2', () => {
    it('should fail', () => {
      expect(true).toBe(false);
    });
  });
});

In the test report, the suite name reads as "Suite1.Suite2". And the screenshot file reference is: ./screenshots/chrome-Suite1.Suite2 should fail.png. How can I stop the xml report being created from being produced without using a period in the name? Because this is what the xml report looks like:
<testcase classname="Suite1.Suite2" name="should fail" time="0.181">.
Thanks!

[JaxxAnik]

Worked around this by changing the generated test suite name like so:

jasmine.getEnv().addReporter(new jasmineReporters.JUnitXmlReporter({
      consolidateAll: true,
      savePath: './reports/',
      filePrefix: 'xmlresults',
      modifySuiteName: function(generatedSuiteName, suite) {
        return generatedSuiteName.replace('.',' ');}
    }));

Note: I'm also using jasmine-reporters to write my test report into xml report

[azachar]

Hello @JaxxAnik, use my fork of this repo (https://github.com/azachar/protractor-screenshoter-plugin) that handle files differently and has no issues like this one. Also, it creates nicer reports and comes with more tested features :)

[JaxxAnik]

Thank you @azachar.I like your reporter. Question for you: If I shard the tests, let's say only on chrome, the report will still be consolidated into one HTML report, right?

[azachar]

If I understood you right, the answer is yes:)

…

On 29 May 2018, at 17:36, jaxxAnik ***@***.***> wrote: Thank you @azachar.I like your reporter. Question for you: If I shard the tests, let's say only on chrome, the report will still be consolidated into one HTML report, right? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#26 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEcXSxxUo4NnZMTK0m3AagxPCTwxELOCks5t3WsKgaJpZM4UK-Zb>.