Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Teardown #2

Open
abongsjoel opened this issue Nov 3, 2020 · 4 comments
Open

Design Teardown #2

abongsjoel opened this issue Nov 3, 2020 · 4 comments

Comments

@abongsjoel
Copy link
Owner

This issue is created for a peer-to-peer code review for team 161 (the palms)

@Wusinho
Copy link

Wusinho commented Nov 3, 2020

-I don't think the blueish and greenish colors don't apply for this project.
-Use Html Semantics

@MrkarlosM
Copy link

It's a pretty good job, just remember that we are looking for a heatmap, so the colors should be a darker gray when the section is most likely to be visited and less dark gray when otherwise.

Also don't forget to add a title to your page changing the Document title to a more descriptive.

@alexisbec
Copy link

Remember to put an empty space between each element in your style sheet. Ex:
.p {
...
}

.article {
...
}

@mricanho
Copy link

mricanho commented Nov 3, 2020

If you change the colors for a darker grey, it will prettier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants