Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destroy Entity keybind no longer works with ACE loaded. #10375

Open
Mike-MF opened this issue Oct 8, 2024 · 2 comments · May be fixed by #10376
Open

Destroy Entity keybind no longer works with ACE loaded. #10375

Mike-MF opened this issue Oct 8, 2024 · 2 comments · May be fixed by #10376
Labels

Comments

@Mike-MF
Copy link
Member

Mike-MF commented Oct 8, 2024

Mods (complete and add to the following information):

  • Arma 3: 2.18
  • CBA: 3.18.0
  • ACE3: 3.18.0

Description:
Cannot kill units via Zeus using the End key (Destroy Entity keybind). But you can kill vehicles with it. Tested it with vanilla and it works fine, tested with just CBA still fine.

Nothing pops in RPT about it.

Steps to reproduce:

  1. Open Zeus
  2. Place any unit
  3. Try to end

Expected behavior:
Should kill people.

Where did the issue occur?

  • Editor (Singleplayer) / Editor (Multiplayer)
@PabstMirror
Copy link
Contributor

It's medical_engine
it gets a handleDamage with _this=[unit,"",1,<NULL-object>,"",-1,<NULL-object>,"",true,0]

I don't think anything has changed so this must be a 2.18 thing?

I guess we just manually handle this match
context == 0 and _sel = "" and _damage = 1 and _ammo = ""
unless this matches something else?

@LinkIsGrim
Copy link
Contributor

LinkIsGrim commented Oct 8, 2024

sel == "" is the same as context == 0

damage == 1 and context == 0 can happen with vehicle hits but ammo should be passed along in that case

tl;dr should work, match context == 0, ammo == "", damage == 1, return damage?

edit: we might want to match the null shooter/instigator as well to be safe

@LinkIsGrim LinkIsGrim linked a pull request Oct 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants