Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling Απαλλαγές Μαθημάτων #4

Open
sakrifor opened this issue Aug 20, 2019 · 2 comments
Open

Handling Απαλλαγές Μαθημάτων #4

sakrifor opened this issue Aug 20, 2019 · 2 comments
Assignees
Labels
question Further information is requested

Comments

@sakrifor
Copy link
Contributor

There are cases where there are Απαλλαγές Μαθημάτων where some have grades and some do not. This case must be resolved in both PDFParser and HTML Parser. In the latter case the issue has been resolved with a hot fix 5452a7c which should be refactored. Cases where the grade of these courses is not specified should be assigned with 5. This matter is open to discussion.

@sakrifor sakrifor added the bug Something isn't working label Aug 20, 2019
@din0s
Copy link
Member

din0s commented Aug 20, 2019

First of all:
Do you know how Course Exemptions actually work for our uni?
Has the student taken the course/examination, and why are they listed separately?

Fixes:
We properly detect them now in HTML & PDF parsers in commits ecfc7d2 and 6df340e respectively.

Missing grades:
We still have to decide what to do with those that don't have a grade.
For now, the csv with the results will just have a blank grade, like so:

NCO-01-05, ΒΑΣΙΚΕΣ ΑΡΧΕΣ ΠΡΟΓΡΑΜΜΑΤΙΣΜΟΥ, Υ, 2018 - 2019, ΦΕΒΡ, 9, 7, 9,

P.S. How come some of them have a grade and some do not?

@din0s din0s self-assigned this Aug 20, 2019
@sakrifor sakrifor added question Further information is requested and removed bug Something isn't working labels Aug 21, 2019
@sakrifor
Copy link
Contributor Author

@din0s I have no idea, let's consider this resolved for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants