You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is not a critical bug but is a usability obstacle for downstream ACTS users. I chose to label this a bug since the CMakeLists.txt including this as an option implies to me that the examples should be able to build without TBB.
I am building ACTS within a fixed environment where TBB is unavailable.
I configure ACTS with
during the configuration step, ACTS acknowledges that it will be built in single-threaded mode.
-- Ignore subdirectory 'Examples/Detectors/MuonSpectrometerMockupDetector'
-- disable TBB for Examples/Framework - only single-threaded running will be supported
-- Ignore subdirectory 'Examples/Framework/ML'
the build of the examples fails when trying to include a tbb header
[ 56%] Building CXX object Examples/Framework/CMakeFiles/ActsExamplesFramework.dir/src/Framework/RandomNumbers.cpp.o
[ 57%] Building CXX object Examples/Framework/CMakeFiles/ActsExamplesFramework.dir/src/Framework/Sequencer.cpp.o
In file included from /home/tom/code/ldmx/acts-tbb/acts/Examples/Framework/src/Framework/Sequencer.cpp:9:
/home/tom/code/ldmx/acts-tbb/acts/Examples/Framework/include/ActsExamples/Framework/Sequencer.hpp:30:10: fatal error: tbb/enumerable_thread_specific.h: No such file or directory
30 | #include <tbb/enumerable_thread_specific.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
gmake[2]: *** [Examples/Framework/CMakeFiles/ActsExamplesFramework.dir/build.make:174: Examples/Framework/CMakeFiles/ActsExamplesFramework.dir/src/Framework/Sequencer.cpp.o] Error 1
gmake[2]: *** Waiting for unfinished jobs....
I'm guessing this is simply an issue with not wrapping the relevant TBB parts in the Sequencer. For example,
We are proceeding forward with simply commenting out the Sequencer compilation from the framework example since we are just trying to get to using the CSV writer (which depends on the writer interface within the framework example).
We didn't end up removing the flag in that PR, but maybe this is reason to do that.
The alternative is to use preprocessor ifs to remove the code that uses tbb conditionally.
I would argue we can just accept that tbb is required for the examples and move on.
This issue/PR has been automatically marked as stale because it has not had recent activity. The stale label will be removed if any interaction occurs.
This is not a critical bug but is a usability obstacle for downstream ACTS users. I chose to label this a bug since the CMakeLists.txt including this as an option implies to me that the examples should be able to build without TBB.
I am building ACTS within a fixed environment where TBB is unavailable.
I configure ACTS with
and then build with
I have uploaded the full command log for review, but the relevant parts are...
during the configuration step, ACTS acknowledges that it will be built in single-threaded mode.
the build of the examples fails when trying to include a tbb header
I'm guessing this is simply an issue with not wrapping the relevant TBB parts in the Sequencer. For example,
acts/Examples/Framework/include/ActsExamples/Framework/Sequencer.hpp
Lines 29 to 31 in d250bbf
acts/Examples/Framework/src/Framework/Sequencer.cpp
Lines 106 to 113 in d250bbf
We are proceeding forward with simply commenting out the Sequencer compilation from the framework example since we are just trying to get to using the CSV writer (which depends on the writer interface within the framework example).
The text was updated successfully, but these errors were encountered: